You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@systemds.apache.org by GitBox <gi...@apache.org> on 2021/03/04 14:06:19 UTC

[GitHub] [systemds] Shafaq-Siddiqi commented on pull request #1189: [DIA] Km and Cox functions

Shafaq-Siddiqi commented on pull request #1189:
URL: https://github.com/apache/systemds/pull/1189#issuecomment-790642122


   Hi,
   Thank you for your contribution. The PR looks in a good shape. Just one minor task if you could please add the R scripts and compare the functions with equivalent R functions. You can have a look into other built-in i.e., winsorize, to see how we are comparing them against R functions. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org