[GitHub] [logging-log4j2] kevinleturc commented on issue #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger

[GitBox <gi...@apache.org>]

kevinleturc commented on issue #351: LOG4J2-1360 - Provide a Log4j implementation of System.Logger
URL: https://github.com/apache/logging-log4j2/pull/351#issuecomment-602175494
 
 
   I added the site section with the right maven plugins to make the build succeed.
   
   In this addition, I faced several issues with tools such as surefire, javadoc, spotbugs or pmd due to toolchain usage. I created a `java11-module` maven profile, activated if jdk is higher than 11, to not loose to many things with the regular build under jdk 8.
   - adding module-info.java makes surefire 2.21 failing.
   we need surefire 2.13 to make forked VM works with toolchain, but with this version we don't test the modular system -> run the build with surefire 2.13 and add under the java 11 profile a surefire 2.21 configuration with forked VM disabled in order to test modular system
   - javadoc doesn't succeed to generate site for classes whose source/target is 9 -> compile everything with a Java 11 LTS
   - sportbugs and pmd run on compiled classes and doesn't support toolchain plugin -> I moved their reports under the java 11 profile

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services