[GitHub] [dubbo] CrazyHZM commented on a diff in pull request #12987: Retry bind if bind failed

["CrazyHZM (via GitHub)" <gi...@apache.org>]

CrazyHZM commented on code in PR #12987:
URL: https://github.com/apache/dubbo/pull/12987#discussion_r1311296611


##########
dubbo-plugin/dubbo-qos/src/main/java/org/apache/dubbo/qos/server/Server.java:
##########
@@ -115,17 +115,33 @@ protected void initChannel(Channel ch) throws Exception {
                 ));
             }
         });
-        try {
-            if (StringUtils.isBlank(host)) {
-                serverBootstrap.bind(port).sync();
+        Throwable lastError = null;
+        for (int i = 0; i < 10; i++) {

Review Comment:
   I recommend adding a server-failed-retry-count  and  server-failed-retry-interval configuration
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org