[GitHub] [trafficserver] bneradt commented on a change in pull request #7673: Change debug tags and make sure sni is printed on certain logs

[GitBox <gi...@apache.org>]

bneradt commented on a change in pull request #7673:
URL: https://github.com/apache/trafficserver/pull/7673#discussion_r606687343



##########
File path: iocore/net/SSLClientUtils.cc
##########
@@ -82,6 +82,11 @@ verify_callback(int signature_ok, X509_STORE_CTX *ctx)
       } else {
         sni_name = buff;
       }
+      if (is_debug_tag_set("ssl_verify")) {
+        Debug("ssl_verify", "Core server certificate verification failed for (%s). Action=%s Error=%s server=%s(%s) depth=%d",
+              sni_name, enforce_mode ? "Terminate" : "Continue", X509_verify_cert_error_string(err),
+              netvc->options.ssl_servername.get(), buff, depth);
+      }

Review comment:
       Are you wrapping these in the conditional because the computation of the parts of the message are expensive?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org