You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "brandboat (via GitHub)" <gi...@apache.org> on 2023/10/04 16:14:48 UTC
[PR] [YUNIKORN-2019] Remove redundant informer call in spark.go ServiceInit [yunikorn-k8shim]
brandboat opened a new pull request, #685:
URL: https://github.com/apache/yunikorn-k8shim/pull/685
### What is this PR for?
https://github.com/apache/yunikorn-k8shim/blob/c633925c39fd69a9a52031ab2ddab5f00e75abb5/pkg/appmgmt/sparkoperator/spark.go#L68-L69
L68 is a redundant since we do it again in next line.
### What type of PR is it?
* [x] - Improvement
### Todos
N/A
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-2019
### How should this be tested?
N/A
### Screenshots (if appropriate)
N/A
### Questions:
N/A
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2019] Remove redundant informer call in spark.go ServiceInit [yunikorn-k8shim]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on PR #685:
URL: https://github.com/apache/yunikorn-k8shim/pull/685#issuecomment-1750879501
The e2e failed cases are not related to spark informer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2019] Remove redundant informer call in spark.go ServiceInit [yunikorn-k8shim]
Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 closed pull request #685: [YUNIKORN-2019] Remove redundant informer call in spark.go ServiceInit
URL: https://github.com/apache/yunikorn-k8shim/pull/685
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [YUNIKORN-2019] Remove redundant informer call in spark.go ServiceInit [yunikorn-k8shim]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #685:
URL: https://github.com/apache/yunikorn-k8shim/pull/685#issuecomment-1749256712
## [Codecov](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/685?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#685](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/685?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (734c73e) into [master](https://app.codecov.io/gh/apache/yunikorn-k8shim/commit/c633925c39fd69a9a52031ab2ddab5f00e75abb5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (c633925) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #685 +/- ##
==========================================
- Coverage 71.81% 71.79% -0.03%
==========================================
Files 51 51
Lines 8105 8105
==========================================
- Hits 5821 5819 -2
- Misses 2084 2086 +2
Partials 200 200
```
[see 1 file with indirect coverage changes](https://app.codecov.io/gh/apache/yunikorn-k8shim/pull/685/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org