You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2026/01/04 20:08:41 UTC
(commons-ognl) branch master updated (d386a68 -> ab27393)
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/commons-ognl.git
from d386a68 Remove dead comments
new ba9c1ce Use a code comment, not Javadoc inside a method
new ab27393 Javadoc
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
Summary of changes:
src/main/java/org/apache/commons/ognl/ASTAnd.java | 1 +
src/main/java/org/apache/commons/ognl/ASTVarRef.java | 1 +
.../org/apache/commons/ognl/ArrayElementsAccessor.java | 1 +
.../apache/commons/ognl/CollectionElementsAccessor.java | 1 +
.../java/org/apache/commons/ognl/ElementsAccessor.java | 1 +
.../apache/commons/ognl/EnumerationElementsAccessor.java | 1 +
.../org/apache/commons/ognl/IteratorElementsAccessor.java | 1 +
.../java/org/apache/commons/ognl/MapElementsAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/MemberAccess.java | 1 +
src/main/java/org/apache/commons/ognl/MethodAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/NodeType.java | 1 +
src/main/java/org/apache/commons/ognl/NullHandler.java | 1 +
.../org/apache/commons/ognl/NumberElementsAccessor.java | 1 +
.../org/apache/commons/ognl/ObjectElementsAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/OgnlException.java | 2 ++
src/main/java/org/apache/commons/ognl/OgnlRuntime.java | 1 +
.../apache/commons/ognl/enhance/ContextClassLoader.java | 1 +
.../org/apache/commons/ognl/test/ArrayElementsTest.java | 14 +++++++-------
.../org/apache/commons/ognl/test/InheritedMethodsTest.java | 1 +
.../commons/ognl/test/enhance/TestExpressionCompiler.java | 1 +
.../org/apache/commons/ognl/test/objects/BaseBean.java | 1 +
.../org/apache/commons/ognl/test/objects/BeanProvider.java | 1 +
.../commons/ognl/test/objects/BeanProviderAccessor.java | 1 +
.../apache/commons/ognl/test/objects/BeanProviderImpl.java | 1 +
.../org/apache/commons/ognl/test/objects/FirstBean.java | 1 +
.../org/apache/commons/ognl/test/objects/SecondBean.java | 1 +
26 files changed, 33 insertions(+), 7 deletions(-)
(commons-ognl) 02/02: Javadoc
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-ognl.git
commit ab27393cee9a92d6ed4c394966fd356be7637177
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jan 4 15:08:36 2026 -0500
Javadoc
Add an empty line before a Javadoc comment
---
src/main/java/org/apache/commons/ognl/ASTAnd.java | 1 +
src/main/java/org/apache/commons/ognl/ASTVarRef.java | 1 +
src/main/java/org/apache/commons/ognl/ArrayElementsAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/CollectionElementsAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/ElementsAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/EnumerationElementsAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/IteratorElementsAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/MapElementsAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/MemberAccess.java | 1 +
src/main/java/org/apache/commons/ognl/MethodAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/NodeType.java | 1 +
src/main/java/org/apache/commons/ognl/NullHandler.java | 1 +
src/main/java/org/apache/commons/ognl/NumberElementsAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/ObjectElementsAccessor.java | 1 +
src/main/java/org/apache/commons/ognl/OgnlException.java | 2 ++
src/main/java/org/apache/commons/ognl/OgnlRuntime.java | 1 +
src/main/java/org/apache/commons/ognl/enhance/ContextClassLoader.java | 1 +
src/test/java/org/apache/commons/ognl/test/InheritedMethodsTest.java | 1 +
.../org/apache/commons/ognl/test/enhance/TestExpressionCompiler.java | 1 +
src/test/java/org/apache/commons/ognl/test/objects/BaseBean.java | 1 +
src/test/java/org/apache/commons/ognl/test/objects/BeanProvider.java | 1 +
.../java/org/apache/commons/ognl/test/objects/BeanProviderAccessor.java | 1 +
.../java/org/apache/commons/ognl/test/objects/BeanProviderImpl.java | 1 +
src/test/java/org/apache/commons/ognl/test/objects/FirstBean.java | 1 +
src/test/java/org/apache/commons/ognl/test/objects/SecondBean.java | 1 +
25 files changed, 26 insertions(+)
diff --git a/src/main/java/org/apache/commons/ognl/ASTAnd.java b/src/main/java/org/apache/commons/ognl/ASTAnd.java
index abad886..b36906e 100644
--- a/src/main/java/org/apache/commons/ognl/ASTAnd.java
+++ b/src/main/java/org/apache/commons/ognl/ASTAnd.java
@@ -29,6 +29,7 @@ import static java.lang.String.format;
public class ASTAnd
extends BooleanExpression
{
+
/** Serial */
private static final long serialVersionUID = -4585941425250141812L;
diff --git a/src/main/java/org/apache/commons/ognl/ASTVarRef.java b/src/main/java/org/apache/commons/ognl/ASTVarRef.java
index ed23c89..c610a75 100644
--- a/src/main/java/org/apache/commons/ognl/ASTVarRef.java
+++ b/src/main/java/org/apache/commons/ognl/ASTVarRef.java
@@ -51,6 +51,7 @@ public class ASTVarRef
{
this.name = name;
}
+
/**
* Gets the variable name.
*
diff --git a/src/main/java/org/apache/commons/ognl/ArrayElementsAccessor.java b/src/main/java/org/apache/commons/ognl/ArrayElementsAccessor.java
index 824dd46..cf40c3a 100644
--- a/src/main/java/org/apache/commons/ognl/ArrayElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/ArrayElementsAccessor.java
@@ -28,6 +28,7 @@ import java.util.Enumeration;
public class ArrayElementsAccessor
implements ElementsAccessor
{
+
/**
* {@inheritDoc}
*/
diff --git a/src/main/java/org/apache/commons/ognl/CollectionElementsAccessor.java b/src/main/java/org/apache/commons/ognl/CollectionElementsAccessor.java
index 8770e54..3fa933e 100644
--- a/src/main/java/org/apache/commons/ognl/CollectionElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/CollectionElementsAccessor.java
@@ -30,6 +30,7 @@ import java.util.Enumeration;
public class CollectionElementsAccessor
implements ElementsAccessor
{
+
/**
* {@inheritDoc}
*/
diff --git a/src/main/java/org/apache/commons/ognl/ElementsAccessor.java b/src/main/java/org/apache/commons/ognl/ElementsAccessor.java
index 973cfdd..2a71465 100644
--- a/src/main/java/org/apache/commons/ognl/ElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/ElementsAccessor.java
@@ -31,6 +31,7 @@ import java.util.Enumeration;
*/
public interface ElementsAccessor
{
+
/**
* Returns an iterator over the elements of the given target object.
*
diff --git a/src/main/java/org/apache/commons/ognl/EnumerationElementsAccessor.java b/src/main/java/org/apache/commons/ognl/EnumerationElementsAccessor.java
index 825856f..4893a86 100644
--- a/src/main/java/org/apache/commons/ognl/EnumerationElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/EnumerationElementsAccessor.java
@@ -28,6 +28,7 @@ import java.util.Enumeration;
public class EnumerationElementsAccessor
implements ElementsAccessor
{
+
/**
* {@inheritDoc}
*/
diff --git a/src/main/java/org/apache/commons/ognl/IteratorElementsAccessor.java b/src/main/java/org/apache/commons/ognl/IteratorElementsAccessor.java
index 061508d..a187f69 100644
--- a/src/main/java/org/apache/commons/ognl/IteratorElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/IteratorElementsAccessor.java
@@ -30,6 +30,7 @@ import java.util.Iterator;
public class IteratorElementsAccessor
implements ElementsAccessor
{
+
/**
* {@inheritDoc}
*/
diff --git a/src/main/java/org/apache/commons/ognl/MapElementsAccessor.java b/src/main/java/org/apache/commons/ognl/MapElementsAccessor.java
index d32fccd..6b657da 100644
--- a/src/main/java/org/apache/commons/ognl/MapElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/MapElementsAccessor.java
@@ -30,6 +30,7 @@ import java.util.Map;
public class MapElementsAccessor
implements ElementsAccessor
{
+
/**
* {@inheritDoc}
*/
diff --git a/src/main/java/org/apache/commons/ognl/MemberAccess.java b/src/main/java/org/apache/commons/ognl/MemberAccess.java
index 77e7350..1f6a067 100644
--- a/src/main/java/org/apache/commons/ognl/MemberAccess.java
+++ b/src/main/java/org/apache/commons/ognl/MemberAccess.java
@@ -28,6 +28,7 @@ import java.util.Map;
*/
public interface MemberAccess
{
+
/**
* Sets the member up for accessibility
*/
diff --git a/src/main/java/org/apache/commons/ognl/MethodAccessor.java b/src/main/java/org/apache/commons/ognl/MethodAccessor.java
index 6353c09..bc95ce7 100644
--- a/src/main/java/org/apache/commons/ognl/MethodAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/MethodAccessor.java
@@ -27,6 +27,7 @@ import java.util.Map;
*/
public interface MethodAccessor
{
+
/**
* Calls the static method named with the arguments given on the class given.
*
diff --git a/src/main/java/org/apache/commons/ognl/NodeType.java b/src/main/java/org/apache/commons/ognl/NodeType.java
index cd6847e..5aeb0f3 100644
--- a/src/main/java/org/apache/commons/ognl/NodeType.java
+++ b/src/main/java/org/apache/commons/ognl/NodeType.java
@@ -25,6 +25,7 @@ package org.apache.commons.ognl;
*/
public interface NodeType
{
+
/**
* The type returned from the expression - if any.
*
diff --git a/src/main/java/org/apache/commons/ognl/NullHandler.java b/src/main/java/org/apache/commons/ognl/NullHandler.java
index 1186da8..9b4724f 100644
--- a/src/main/java/org/apache/commons/ognl/NullHandler.java
+++ b/src/main/java/org/apache/commons/ognl/NullHandler.java
@@ -27,6 +27,7 @@ import java.util.Map;
*/
public interface NullHandler
{
+
/**
* Method called on target returned null.
*/
diff --git a/src/main/java/org/apache/commons/ognl/NumberElementsAccessor.java b/src/main/java/org/apache/commons/ognl/NumberElementsAccessor.java
index 56ea84d..f09eb33 100644
--- a/src/main/java/org/apache/commons/ognl/NumberElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/NumberElementsAccessor.java
@@ -28,6 +28,7 @@ import java.util.NoSuchElementException;
public class NumberElementsAccessor
implements ElementsAccessor, NumericTypes
{
+
/**
* {@inheritDoc}
*/
diff --git a/src/main/java/org/apache/commons/ognl/ObjectElementsAccessor.java b/src/main/java/org/apache/commons/ognl/ObjectElementsAccessor.java
index 7014264..0b92cb7 100644
--- a/src/main/java/org/apache/commons/ognl/ObjectElementsAccessor.java
+++ b/src/main/java/org/apache/commons/ognl/ObjectElementsAccessor.java
@@ -27,6 +27,7 @@ import java.util.Enumeration;
public class ObjectElementsAccessor
implements ElementsAccessor
{
+
/**
* {@inheritDoc}
*/
diff --git a/src/main/java/org/apache/commons/ognl/OgnlException.java b/src/main/java/org/apache/commons/ognl/OgnlException.java
index a9da138..2260516 100644
--- a/src/main/java/org/apache/commons/ognl/OgnlException.java
+++ b/src/main/java/org/apache/commons/ognl/OgnlException.java
@@ -41,6 +41,7 @@ public class OgnlException
}
catch ( NoSuchMethodException e )
{
+
/** ignore */
}
}
@@ -92,6 +93,7 @@ public class OgnlException
}
catch ( Exception ignored )
{
+
/** ignore */
}
}
diff --git a/src/main/java/org/apache/commons/ognl/OgnlRuntime.java b/src/main/java/org/apache/commons/ognl/OgnlRuntime.java
index 5e1a166..17e593a 100644
--- a/src/main/java/org/apache/commons/ognl/OgnlRuntime.java
+++ b/src/main/java/org/apache/commons/ognl/OgnlRuntime.java
@@ -60,6 +60,7 @@ import java.util.Map;
*/
public class OgnlRuntime
{
+
/**
* Constant expression used to indicate that a given method / property couldn't be found during reflection
* operations.
diff --git a/src/main/java/org/apache/commons/ognl/enhance/ContextClassLoader.java b/src/main/java/org/apache/commons/ognl/enhance/ContextClassLoader.java
index f8814f1..e12b87d 100644
--- a/src/main/java/org/apache/commons/ognl/enhance/ContextClassLoader.java
+++ b/src/main/java/org/apache/commons/ognl/enhance/ContextClassLoader.java
@@ -40,6 +40,7 @@ public class ContextClassLoader
* =================================================================== Overridden methods
* ===================================================================
*/
+
/**
* {@inheritDoc}
*/
diff --git a/src/test/java/org/apache/commons/ognl/test/InheritedMethodsTest.java b/src/test/java/org/apache/commons/ognl/test/InheritedMethodsTest.java
index 3631772..d2d62ce 100644
--- a/src/test/java/org/apache/commons/ognl/test/InheritedMethodsTest.java
+++ b/src/test/java/org/apache/commons/ognl/test/InheritedMethodsTest.java
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+
/**
*/
package org.apache.commons.ognl.test;
diff --git a/src/test/java/org/apache/commons/ognl/test/enhance/TestExpressionCompiler.java b/src/test/java/org/apache/commons/ognl/test/enhance/TestExpressionCompiler.java
index d7d395f..426e397 100644
--- a/src/test/java/org/apache/commons/ognl/test/enhance/TestExpressionCompiler.java
+++ b/src/test/java/org/apache/commons/ognl/test/enhance/TestExpressionCompiler.java
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+
/**
*/
package org.apache.commons.ognl.test.enhance;
diff --git a/src/test/java/org/apache/commons/ognl/test/objects/BaseBean.java b/src/test/java/org/apache/commons/ognl/test/objects/BaseBean.java
index f89e6e6..cd6a37c 100644
--- a/src/test/java/org/apache/commons/ognl/test/objects/BaseBean.java
+++ b/src/test/java/org/apache/commons/ognl/test/objects/BaseBean.java
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+
/**
*/
package org.apache.commons.ognl.test.objects;
diff --git a/src/test/java/org/apache/commons/ognl/test/objects/BeanProvider.java b/src/test/java/org/apache/commons/ognl/test/objects/BeanProvider.java
index 6242428..2cd980a 100644
--- a/src/test/java/org/apache/commons/ognl/test/objects/BeanProvider.java
+++ b/src/test/java/org/apache/commons/ognl/test/objects/BeanProvider.java
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+
/**
*/
package org.apache.commons.ognl.test.objects;
diff --git a/src/test/java/org/apache/commons/ognl/test/objects/BeanProviderAccessor.java b/src/test/java/org/apache/commons/ognl/test/objects/BeanProviderAccessor.java
index 6dbffed..7681890 100644
--- a/src/test/java/org/apache/commons/ognl/test/objects/BeanProviderAccessor.java
+++ b/src/test/java/org/apache/commons/ognl/test/objects/BeanProviderAccessor.java
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+
/**
*/
package org.apache.commons.ognl.test.objects;
diff --git a/src/test/java/org/apache/commons/ognl/test/objects/BeanProviderImpl.java b/src/test/java/org/apache/commons/ognl/test/objects/BeanProviderImpl.java
index 254485e..20ab23e 100644
--- a/src/test/java/org/apache/commons/ognl/test/objects/BeanProviderImpl.java
+++ b/src/test/java/org/apache/commons/ognl/test/objects/BeanProviderImpl.java
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+
/**
*/
package org.apache.commons.ognl.test.objects;
diff --git a/src/test/java/org/apache/commons/ognl/test/objects/FirstBean.java b/src/test/java/org/apache/commons/ognl/test/objects/FirstBean.java
index 1393a93..a889415 100644
--- a/src/test/java/org/apache/commons/ognl/test/objects/FirstBean.java
+++ b/src/test/java/org/apache/commons/ognl/test/objects/FirstBean.java
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+
/**
*/
package org.apache.commons.ognl.test.objects;
diff --git a/src/test/java/org/apache/commons/ognl/test/objects/SecondBean.java b/src/test/java/org/apache/commons/ognl/test/objects/SecondBean.java
index 39c2b82..29fdb25 100644
--- a/src/test/java/org/apache/commons/ognl/test/objects/SecondBean.java
+++ b/src/test/java/org/apache/commons/ognl/test/objects/SecondBean.java
@@ -16,6 +16,7 @@
* specific language governing permissions and limitations
* under the License.
*/
+
/**
*/
package org.apache.commons.ognl.test.objects;
(commons-ognl) 01/02: Use a code comment, not Javadoc inside a method
Posted by gg...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-ognl.git
commit ba9c1ce9642e37908dccf3a5901362554826808c
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sun Jan 4 15:07:34 2026 -0500
Use a code comment, not Javadoc inside a method
---
.../org/apache/commons/ognl/test/ArrayElementsTest.java | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/src/test/java/org/apache/commons/ognl/test/ArrayElementsTest.java b/src/test/java/org/apache/commons/ognl/test/ArrayElementsTest.java
index 0b1b5f6..e855981 100644
--- a/src/test/java/org/apache/commons/ognl/test/ArrayElementsTest.java
+++ b/src/test/java/org/apache/commons/ognl/test/ArrayElementsTest.java
@@ -120,12 +120,12 @@ public class ArrayElementsTest
public void setUp()
{
super.setUp();
- /**
- * TypeConverter arrayConverter;
- * arrayConverter = new DefaultTypeConverter() { public Object convertValue(Map context, Object target, Member
- * member, String propertyName, Object value, Class toType) { if (value.getClass().isArray()) { if
- * (!toType.isArray()) { value = Array.get(value, 0); } } return super.convertValue(context, target, member,
- * propertyName, value, toType); } }; _context.setTypeConverter(arrayConverter);
- */
+ //
+ // TypeConverter arrayConverter;
+ // arrayConverter = new DefaultTypeConverter() { public Object convertValue(Map context, Object target, Member
+ // member, String propertyName, Object value, Class toType) { if (value.getClass().isArray()) { if
+ // (!toType.isArray()) { value = Array.get(value, 0); } } return super.convertValue(context, target, member,
+ // propertyName, value, toType); } }; _context.setTypeConverter(arrayConverter);
+ //
}
}