[jira] [Comment Edited] (MESOS-7975) The command/default/docker executor can incorrectly send a TASK_FINISHED update even when the task is killed

["Qian Zhang (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-7975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16166060#comment-16166060 ] 

Qian Zhang edited comment on MESOS-7975 at 9/29/17 7:31 AM:
------------------------------------------------------------

RR:
https://reviews.apache.org/r/62685/
https://reviews.apache.org/r/62326/
https://reviews.apache.org/r/62327/


was (Author: qianzhang):
RR:
https://reviews.apache.org/r/62326/
https://reviews.apache.org/r/62327/

> The command/default/docker executor can incorrectly send a TASK_FINISHED update even when the task is killed
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: MESOS-7975
>                 URL: https://issues.apache.org/jira/browse/MESOS-7975
>             Project: Mesos
>          Issue Type: Bug
>            Reporter: Anand Mazumdar
>            Assignee: Qian Zhang
>            Priority: Critical
>              Labels: mesosphere
>
> Currently, when a task is killed, the default/command/docker executor incorrectly send a {{TASK_FINISHED}} status update instead of {{TASK_KILLED}}. This is due to an unfortunate missed conditional check when the task exits with a zero status code.
> {code}
>       if (WSUCCEEDED(status)) {
>         taskState = TASK_FINISHED;
>       } else if (killed) {
>         // Send TASK_KILLED if the task was killed as a result of
>         // kill() or shutdown().
>         taskState = TASK_KILLED;
>       } else {
>         taskState = TASK_FAILED;
>       }
> {code}
> We should modify the code to correctly send {{TASK_KILLED}} status updates when a task is killed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)