svn commit: r1756682 - in /jmeter/trunk: src/core/org/apache/jmeter/reporters/ResultCollector.java xdocs/usermanual/component_reference.xml

[un...@apache.org]

Author: undera
Date: Wed Aug 17 20:24:21 2016
New Revision: 1756682

URL: http://svn.apache.org/viewvc?rev=1756682&view=rev
Log:
Bug 59973 - document non-standard XML in docs and code

Modified:
    jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
    jmeter/trunk/xdocs/usermanual/component_reference.xml

Modified: jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java?rev=1756682&r1=1756681&r2=1756682&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/reporters/ResultCollector.java Wed Aug 17 20:24:21 2016
@@ -79,6 +79,7 @@ public class ResultCollector extends Abs
 
     private static final String TESTRESULTS_END = "</testResults>"; // $NON-NLS-1$
 
+    // we have to use version 1.0, see bug 59973
     private static final String XML_HEADER = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>"; // $NON-NLS-1$
 
     private static final int MIN_XML_FILE_LEN = XML_HEADER.length() + TESTRESULTS_START.length()

Modified: jmeter/trunk/xdocs/usermanual/component_reference.xml
URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/usermanual/component_reference.xml?rev=1756682&r1=1756681&r2=1756682&view=diff
==============================================================================
--- jmeter/trunk/xdocs/usermanual/component_reference.xml (original)
+++ jmeter/trunk/xdocs/usermanual/component_reference.xml Wed Aug 17 20:24:21 2016
@@ -2679,6 +2679,10 @@ before loading the file.
 <p>Results can be read from XML or CSV format files.
 When reading from CSV results files, the header (if present) is used to determine which fields are present.
 <b>In order to interpret a header-less CSV file correctly, the appropriate properties must be set in <code>jmeter.properties</code>.</b>
+<note>
+XML files written by JMeter have version 1.0 declared in header while actual file is serialized with 1.1 rules. 
+This causes strict XML parsers to fail. Consider using non-string XML parsers to read JTL files.
+</note>
 </p>
 <note>
 The file name can contain function and/or variable references.