[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #4550: [feature][catalog] Support for multiplexing connections

["EricJoy2048 (via GitHub)" <gi...@apache.org>]

EricJoy2048 commented on code in PR #4550:
URL: https://github.com/apache/incubator-seatunnel/pull/4550#discussion_r1170823227


##########
seatunnel-api/src/main/java/org/apache/seatunnel/api/table/catalog/CatalogTableUtil.java:
##########
@@ -126,8 +123,9 @@ public static List<CatalogTable> getCatalogTables(Config config, ClassLoader cla
                 .map(
                         catalog -> {
                             long startTime = System.currentTimeMillis();
-                            List<CatalogTable> catalogTables =
-                                    getCatalogTables(catalogConfig, catalog);
+                            catalog.open();
+                            List<CatalogTable> catalogTables = catalog.getTables(catalogConfig);
+                            catalog.close();

Review Comment:
   If a program exception occurs before the `catalog.close()` method, will the connection be closed?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org