You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Eric Shu <es...@pivotal.io> on 2016/06/13 16:58:33 UTC
Review Request 48652: GEODE-1517: Transaction could still proceed
after TXManagerImpl is closing during cache close
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48652/
-----------------------------------------------------------
Review request for geode, Darrel Schneider and Swapnil Bawaskar.
Bugs: GEODE-1517
https://issues.apache.org/jira/browse/GEODE-1517
Repository: geode
Description
-------
Holding the ReentrantLock during TXManagerImpl.close() when closing TXStateProxyImpl. Provent any TXStateProxyImpl to work further.
Add a test case where it fails without the above fix and passes after the fix.
Also avoid going through synchronized failover map to check if a TXStateProxyImpl is finished, instead, use its isInProgress() call.
Diffs
-----
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessage.java 19e1dea
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java 2608878
geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 1b83ee3
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessageTest.java ecfc2b0
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java ce24947
geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessageTest.java bbbf714
Diff: https://reviews.apache.org/r/48652/diff/
Testing
-------
precheckin
Thanks,
Eric Shu
Re: Review Request 48652: GEODE-1517: Transaction could still proceed
after TXManagerImpl is closing during cache close
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48652/#review137422
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On June 13, 2016, 9:58 a.m., Eric Shu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48652/
> -----------------------------------------------------------
>
> (Updated June 13, 2016, 9:58 a.m.)
>
>
> Review request for geode, Darrel Schneider and Swapnil Bawaskar.
>
>
> Bugs: GEODE-1517
> https://issues.apache.org/jira/browse/GEODE-1517
>
>
> Repository: geode
>
>
> Description
> -------
>
> Holding the ReentrantLock during TXManagerImpl.close() when closing TXStateProxyImpl. Provent any TXStateProxyImpl to work further.
> Add a test case where it fails without the above fix and passes after the fix.
>
> Also avoid going through synchronized failover map to check if a TXStateProxyImpl is finished, instead, use its isInProgress() call.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessage.java 19e1dea
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/TXManagerImpl.java 2608878
> geode-core/src/main/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessage.java 1b83ee3
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/RemoteOperationMessageTest.java ecfc2b0
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/TXManagerImplTest.java ce24947
> geode-core/src/test/java/com/gemstone/gemfire/internal/cache/partitioned/PartitionMessageTest.java bbbf714
>
> Diff: https://reviews.apache.org/r/48652/diff/
>
>
> Testing
> -------
>
> precheckin
>
>
> Thanks,
>
> Eric Shu
>
>