You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/07/27 14:01:27 UTC
[GitHub] [incubator-kyuubi] zhouyifan279 opened a new pull request, #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiSpark
zhouyifan279 opened a new pull request, #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155
### _Why are the changes needed?_
Close #3154
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [x] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhouyifan279 commented on a diff in pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiDB/TiKV
Posted by GitBox <gi...@apache.org>.
zhouyifan279 commented on code in PR #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155#discussion_r931763872
##########
docs/connector/spark/tispark.rst:
##########
@@ -16,21 +16,86 @@
`TiSpark`_
==========
+TiSpark is a thin layer built for running Apache Spark on top of TiDB/TiKV to answer complex OLAP
+queries. It enjoys the merits of both the Spark platform and the distributed clusters of TiKV while
+seamlessly integrated to TiDB, a distributed OLTP database, to provide one-stop Hybrid
+Transactional/Analytical Processing (HTAP) solutions for online transactions and analyses.
+
+.. tip::
+ This article assumes that you have mastered the basic knowledge and operation of TiSpark.
+ For the knowledge about TiSpark not mentioned in this article,
+ you can obtain it from its `Official Documentation`_.
+
+By using kyuubi, we can run SQL queries towards TiSpark which is more
+convenient, easy to understand, and easy to expand than directly using
+spark to manipulate TiSpark.
+
TiSpark Integration
-------------------
+To enable the integration of kyuubi spark sql engine and TiSpark through
+Apache Spark Datasource V2 and Catalog APIs, you need to:
+
+- Referencing the :ref:`dependencies`
+- Setting the spark extension and catalog :ref:`configurations`
+
.. _dependencies:
Dependencies
************
+The classpath of kyuubi spark sql engine with TiSpark supported consists of
+
+1. kyuubi-spark-sql-engine-|release|.jar, the engine jar deployed with Kyuubi distributions
+2. a copy of spark distribution
+3. tispark-assembly-<spark.version>_<scala.version>-<tispark.version>.jar (example: tispark-assembly-3.2_2.12-3.0.1.jar), which can be found in the `Maven Central`_
+
+In order to make the TiSpark packages visible for the runtime classpath of engines, we can use one of these methods:
+
+1. Put the TiSpark packages into ``$SPARK_HOME/jars`` directly
+2. Set ``spark.jars=/path/to/tispark-assembly``
+
+.. warning::
+ Please mind the compatibility of different TiDB, TiSpark and Spark versions, which can be confirmed on the page of `Environment setup`_.
.. _configurations:
Configurations
**************
+To activate functionality of TiSpark, we can set the following configurations:
+
+.. code-block:: properties
+
+ spark.tispark.pd.addresses $pd_host:$pd_port
+ spark.sql.extensions org.apache.spark.sql.TiExtensions
+ spark.sql.catalog.tidb_catalog org.apache.spark.sql.catalyst.catalog.TiCatalog
+ spark.sql.catalog.tidb_catalog.pd.addresses $pd_host:$pd_port
+
+The `spark.tispark.pd.addresses` and `spark.sql.catalog.tidb_catalog.pd.addresses` configurations
+allow you to put in multiple PD servers. Specify the port number for each of them.
+
+For example, when you have multiple PD servers on `10.16.20.1,10.16.20.2,10.16.20.3` with the port `2379`,
+put it as `10.16.20.1:2379,10.16.20.2:2379,10.16.20.3:2379`.
TiSpark Operations
------------------
-.. _TiSpark: https://docs.pingcap.com/tidb/dev/tispark-overview
\ No newline at end of file
+Taking ``SELECT`` as a example,
+
+.. code-block:: sql
+
+ SELECT * FROM foo;
+
+Taking ``DELETE FROM`` as a example, Spark 3 added support for DELETE FROM queries to remove data from tables.
+
+.. code-block:: sql
+
+ DELETE FROM foo WHERE id >= 1 and id < 2;
+
+.. note::
+ As for now (TiSpark 3.0.1), TiSpark does not support ``CREATE TABLE``, ``INSERT INTO/OVERWRITE``` operations
Review Comment:
Thanks, fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhaomin1423 commented on a diff in pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiSpark
Posted by GitBox <gi...@apache.org>.
zhaomin1423 commented on code in PR #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155#discussion_r931674636
##########
docs/connector/spark/tispark.rst:
##########
@@ -16,21 +16,86 @@
`TiSpark`_
==========
+TiSpark is a thin layer built for running Apache Spark on top of TiDB/TiKV to answer complex OLAP
+queries. It enjoys the merits of both the Spark platform and the distributed clusters of TiKV while
+seamlessly integrated to TiDB, a distributed OLTP database, to provide one-stop Hybrid
+Transactional/Analytical Processing (HTAP) solutions for online transactions and analyses.
+
+.. tip::
+ This article assumes that you have mastered the basic knowledge and operation of TiSpark.
+ For the knowledge about TiSpark not mentioned in this article,
+ you can obtain it from its `Official Documentation`_.
+
+By using kyuubi, we can run SQL queries towards TiSpark which is more
+convenient, easy to understand, and easy to expand than directly using
+spark to manipulate TiSpark.
+
TiSpark Integration
-------------------
+To enable the integration of kyuubi spark sql engine and TiSpark through
+Apache Spark Datasource V2 and Catalog APIs, you need to:
+
+- Referencing the :ref:`dependencies`
+- Setting the spark extension and catalog :ref:`configurations`
+
.. _dependencies:
Dependencies
************
+The classpath of kyuubi spark sql engine with TiSpark supported consists of
+
+1. kyuubi-spark-sql-engine-|release|.jar, the engine jar deployed with Kyuubi distributions
+2. a copy of spark distribution
+3. tispark-assembly-<spark.version>_<scala.version>-<tispark.version>.jar (example: tispark-assembly-3.2_2.12-3.0.1.jar), which can be found in the `Maven Central`_
+
+In order to make the TiSpark packages visible for the runtime classpath of engines, we can use one of these methods:
+
+1. Put the TiSpark packages into ``$SPARK_HOME/jars`` directly
+2. Set ``spark.jars=/path/to/tispark-assembly``
+
+.. warning::
+ Please mind the compatibility of different TiDB, TiSpark and Spark versions, which can be confirmed on the page of `Environment setup`_.
.. _configurations:
Configurations
**************
+To activate functionality of TiSpark, we can set the following configurations:
+
+.. code-block:: properties
+
+ spark.tispark.pd.addresses $pd_host:$pd_port
+ spark.sql.extensions org.apache.spark.sql.TiExtensions
+ spark.sql.catalog.tidb_catalog org.apache.spark.sql.catalyst.catalog.TiCatalog
+ spark.sql.catalog.tidb_catalog.pd.addresses $pd_host:$pd_port
+
+The `spark.tispark.pd.addresses` and `spark.sql.catalog.tidb_catalog.pd.addresses` configurations
+allow you to put in multiple PD servers. Specify the port number for each of them.
+
+For example, when you have multiple PD servers on `10.16.20.1,10.16.20.2,10.16.20.3` with the port `2379`,
+put it as `10.16.20.1:2379,10.16.20.2:2379,10.16.20.3:2379`.
TiSpark Operations
------------------
-.. _TiSpark: https://docs.pingcap.com/tidb/dev/tispark-overview
\ No newline at end of file
+Taking ``SELECT`` as a example,
+
+.. code-block:: sql
+
+ SELECT * FROM foo;
+
+Taking ``DELETE FROM`` as a example, Spark 3 added support for DELETE FROM queries to remove data from tables.
+
+.. code-block:: sql
+
+ DELETE FROM foo WHERE id >= 1 and id < 2;
+
+.. note::
+ As for now (TiSpark 3.0.1), TiSpark does not support ``CREATE TABLE``, ``INSERT INTO/OVERWRITE``` operations
Review Comment:
After `***/OVERWRITE`, there is a redundant `.
<img width="1244" alt="image" src="https://user-images.githubusercontent.com/49054376/181393015-659e1a6a-6943-45a4-aa72-826cf5aaae2a.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiDB/TiKV
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on code in PR #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155#discussion_r931796344
##########
docs/connector/spark/tidb.rst:
##########
@@ -0,0 +1,103 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+`TiDB`_
+==========
+
+TiDB is an open-source NewSQL database that supports Hybrid Transactional and Analytical Processing
+(HTAP) workloads.
+
+TiSpark is a thin layer built for running Apache Spark on top of TiDB/TiKV to answer complex OLAP
+queries. It enjoys the merits of both the Spark platform and the distributed clusters
+of TiKV while seamlessly integrated to TiDB to provide one-stop HTAP solutions for online
+transactions and analyses.
+
+.. tip::
+ This article assumes that you have mastered the basic knowledge and operation of TiDB and TiSpark.
+ For the knowledge not mentioned in this article, you can obtain it from TiDB `Official Documentation`_.
+
+By using kyuubi, we can run SQL queries towards TiDB/TiKV which is more
+convenient, easy to understand, and easy to expand than directly using
+spark to manipulate TiDB/TiKV.
+
+TiDB Integration
+-------------------
+
+To enable the integration of kyuubi spark sql engine and TiDB through
+Apache Spark Datasource V2 and Catalog APIs, you need to:
+
+- Referencing the TiSpark :ref:`dependencies`
+- Setting the spark extension and catalog :ref:`configurations`
+
+.. _dependencies:
+
+Dependencies
+************
+The classpath of kyuubi spark sql engine with TiDB supported consists of
+
+1. kyuubi-spark-sql-engine-|release|.jar, the engine jar deployed with Kyuubi distributions
+2. a copy of spark distribution
+3. tispark-assembly-<spark.version>_<scala.version>-<tispark.version>.jar (example: tispark-assembly-3.2_2.12-3.0.1.jar), which can be found in the `Maven Central`_
+
+In order to make the TiSpark packages visible for the runtime classpath of engines, we can use one of these methods:
+
+1. Put the TiSpark packages into ``$SPARK_HOME/jars`` directly
+2. Set ``spark.jars=/path/to/tispark-assembly``
+
+.. warning::
+ Please mind the compatibility of different TiDB, TiSpark and Spark versions, which can be confirmed on the page of `Environment setup`_.
+
+.. _configurations:
+
+Configurations
+**************
+
+To activate functionality of TiSpark, we can set the following configurations:
+
+.. code-block:: properties
+
+ spark.tispark.pd.addresses $pd_host:$pd_port
+ spark.sql.extensions org.apache.spark.sql.TiExtensions
+ spark.sql.catalog.tidb_catalog org.apache.spark.sql.catalyst.catalog.TiCatalog
+ spark.sql.catalog.tidb_catalog.pd.addresses $pd_host:$pd_port
+
+The `spark.tispark.pd.addresses` and `spark.sql.catalog.tidb_catalog.pd.addresses` configurations
+allow you to put in multiple PD servers. Specify the port number for each of them.
+
+For example, when you have multiple PD servers on `10.16.20.1,10.16.20.2,10.16.20.3` with the port `2379`,
+put it as `10.16.20.1:2379,10.16.20.2:2379,10.16.20.3:2379`.
+
+TiDB Operations
+------------------
+
+Taking ``SELECT`` as a example,
+
+.. code-block:: sql
+
+ SELECT * FROM foo;
+
+Taking ``DELETE FROM`` as a example, Spark 3 added support for DELETE FROM queries to remove data from tables.
+
+.. code-block:: sql
+
+ DELETE FROM foo WHERE id >= 1 and id < 2;
+
+.. note::
+ As for now (TiSpark 3.0.1), TiSpark does not support ``CREATE TABLE``, ``INSERT INTO/OVERWRITE`` operations
+ through Apache Spark Datasource V2 and Catalog APIs.
+
+.. _Official Documentation: https://docs.pingcap.com/tidb/stable/overview
+.. _Maven Central: https://repo1.maven.org/maven2/com/pingcap/tispark/
+.. _Environment setup: https://docs.pingcap.com/tidb/stable/tispark-overview#environment-setup
Review Comment:
TiSpark Environment setup
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiDB/TiKV
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiDB/TiKV
URL: https://github.com/apache/incubator-kyuubi/pull/3155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiSpark
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155#issuecomment-1196893012
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#3155](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (73b4fc8) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/eb96db54d419d43f7527f8202f9b862af9c4ff69?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (eb96db5) will **increase** coverage by `0.07%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #3155 +/- ##
============================================
+ Coverage 51.33% 51.40% +0.07%
Complexity 6 6
============================================
Files 458 456 -2
Lines 25388 25328 -60
Branches 3535 3519 -16
============================================
- Hits 13032 13019 -13
+ Misses 11113 11063 -50
- Partials 1243 1246 +3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...main/java/org/apache/kyuubi/jdbc/KyuubiDriver.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWhpdmUtamRiYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUva3l1dWJpL2pkYmMvS3l1dWJpRHJpdmVyLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../apache/kyuubi/client/api/v1/dto/BatchRequest.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vQmF0Y2hSZXF1ZXN0LmphdmE=) | `52.94% <0.00%> (-17.06%)` | :arrow_down: |
| [...g/apache/kyuubi/client/api/v1/dto/VersionInfo.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vVmVyc2lvbkluZm8uamF2YQ==) | `53.84% <0.00%> (-4.49%)` | :arrow_down: |
| [...apache/kyuubi/client/api/v1/dto/SessionHandle.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vU2Vzc2lvbkhhbmRsZS5qYXZh) | `53.84% <0.00%> (-4.49%)` | :arrow_down: |
| [...ache/kyuubi/client/api/v1/dto/OpActionRequest.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vT3BBY3Rpb25SZXF1ZXN0LmphdmE=) | `53.84% <0.00%> (-4.49%)` | :arrow_down: |
| [...che/kyuubi/client/api/v1/dto/SessionOpenCount.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vU2Vzc2lvbk9wZW5Db3VudC5qYXZh) | `53.84% <0.00%> (-4.49%)` | :arrow_down: |
| [...e/kyuubi/client/api/v1/dto/CloseBatchResponse.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vQ2xvc2VCYXRjaFJlc3BvbnNlLmphdmE=) | `68.42% <0.00%> (-3.81%)` | :arrow_down: |
| [...ava/org/apache/kyuubi/client/api/v1/dto/Field.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vRmllbGQuamF2YQ==) | `61.11% <0.00%> (-3.60%)` | :arrow_down: |
| [...rg/apache/kyuubi/client/api/v1/dto/InfoDetail.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vSW5mb0RldGFpbC5qYXZh) | `61.11% <0.00%> (-3.60%)` | :arrow_down: |
| [...he/kyuubi/client/api/v1/dto/ExecPoolStatistic.java](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXJlc3QtY2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9reXV1YmkvY2xpZW50L2FwaS92MS9kdG8vRXhlY1Bvb2xTdGF0aXN0aWMuamF2YQ==) | `61.11% <0.00%> (-3.60%)` | :arrow_down: |
| ... and [45 more](https://codecov.io/gh/apache/incubator-kyuubi/pull/3155/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiDB/TiKV
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155#issuecomment-1197586638
I mean the doc title
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhouyifan279 commented on pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiSpark
Posted by GitBox <gi...@apache.org>.
zhouyifan279 commented on PR #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155#issuecomment-1196809171
cc @yaooqinn @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiSpark
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155#issuecomment-1197569928
we can rename the title from `TiSpark`_ to TiDB/TiKv？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiDB/TiKV
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on PR #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155#issuecomment-1197714583
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhouyifan279 commented on pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiDB/TiKV
Posted by GitBox <gi...@apache.org>.
zhouyifan279 commented on PR #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155#issuecomment-1197635937
> we can rename the title from `TiSpark`_ to TiDB/TiKv？
1. Changed doc title and some sub-titles.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] zhouyifan279 commented on a diff in pull request #3155: [KYUUBI #3154][Subtask] Connectors for Spark SQL Query Engine -> TiDB/TiKV
Posted by GitBox <gi...@apache.org>.
zhouyifan279 commented on code in PR #3155:
URL: https://github.com/apache/incubator-kyuubi/pull/3155#discussion_r931798986
##########
docs/connector/spark/tidb.rst:
##########
@@ -0,0 +1,103 @@
+.. Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+.. http://www.apache.org/licenses/LICENSE-2.0
+
+.. Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+`TiDB`_
+==========
+
+TiDB is an open-source NewSQL database that supports Hybrid Transactional and Analytical Processing
+(HTAP) workloads.
+
+TiSpark is a thin layer built for running Apache Spark on top of TiDB/TiKV to answer complex OLAP
+queries. It enjoys the merits of both the Spark platform and the distributed clusters
+of TiKV while seamlessly integrated to TiDB to provide one-stop HTAP solutions for online
+transactions and analyses.
+
+.. tip::
+ This article assumes that you have mastered the basic knowledge and operation of TiDB and TiSpark.
+ For the knowledge not mentioned in this article, you can obtain it from TiDB `Official Documentation`_.
+
+By using kyuubi, we can run SQL queries towards TiDB/TiKV which is more
+convenient, easy to understand, and easy to expand than directly using
+spark to manipulate TiDB/TiKV.
+
+TiDB Integration
+-------------------
+
+To enable the integration of kyuubi spark sql engine and TiDB through
+Apache Spark Datasource V2 and Catalog APIs, you need to:
+
+- Referencing the TiSpark :ref:`dependencies`
+- Setting the spark extension and catalog :ref:`configurations`
+
+.. _dependencies:
+
+Dependencies
+************
+The classpath of kyuubi spark sql engine with TiDB supported consists of
+
+1. kyuubi-spark-sql-engine-|release|.jar, the engine jar deployed with Kyuubi distributions
+2. a copy of spark distribution
+3. tispark-assembly-<spark.version>_<scala.version>-<tispark.version>.jar (example: tispark-assembly-3.2_2.12-3.0.1.jar), which can be found in the `Maven Central`_
+
+In order to make the TiSpark packages visible for the runtime classpath of engines, we can use one of these methods:
+
+1. Put the TiSpark packages into ``$SPARK_HOME/jars`` directly
+2. Set ``spark.jars=/path/to/tispark-assembly``
+
+.. warning::
+ Please mind the compatibility of different TiDB, TiSpark and Spark versions, which can be confirmed on the page of `Environment setup`_.
+
+.. _configurations:
+
+Configurations
+**************
+
+To activate functionality of TiSpark, we can set the following configurations:
+
+.. code-block:: properties
+
+ spark.tispark.pd.addresses $pd_host:$pd_port
+ spark.sql.extensions org.apache.spark.sql.TiExtensions
+ spark.sql.catalog.tidb_catalog org.apache.spark.sql.catalyst.catalog.TiCatalog
+ spark.sql.catalog.tidb_catalog.pd.addresses $pd_host:$pd_port
+
+The `spark.tispark.pd.addresses` and `spark.sql.catalog.tidb_catalog.pd.addresses` configurations
+allow you to put in multiple PD servers. Specify the port number for each of them.
+
+For example, when you have multiple PD servers on `10.16.20.1,10.16.20.2,10.16.20.3` with the port `2379`,
+put it as `10.16.20.1:2379,10.16.20.2:2379,10.16.20.3:2379`.
+
+TiDB Operations
+------------------
+
+Taking ``SELECT`` as a example,
+
+.. code-block:: sql
+
+ SELECT * FROM foo;
+
+Taking ``DELETE FROM`` as a example, Spark 3 added support for DELETE FROM queries to remove data from tables.
+
+.. code-block:: sql
+
+ DELETE FROM foo WHERE id >= 1 and id < 2;
+
+.. note::
+ As for now (TiSpark 3.0.1), TiSpark does not support ``CREATE TABLE``, ``INSERT INTO/OVERWRITE`` operations
+ through Apache Spark Datasource V2 and Catalog APIs.
+
+.. _Official Documentation: https://docs.pingcap.com/tidb/stable/overview
+.. _Maven Central: https://repo1.maven.org/maven2/com/pingcap/tispark/
+.. _Environment setup: https://docs.pingcap.com/tidb/stable/tispark-overview#environment-setup
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org