You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cocoon.apache.org by Unico Hommes <Un...@hippo.nl> on 2004/02/17 18:26:55 UTC
RE: cvs commit: cocoon-2.1/src/blocks/repository/java/org/apache/cocoon/components/source/impl RepositorySourceFactory.java RepositorySource.java
Gianugo,
Unfortunately I had to undo your previous change to the getScheme()
method. This method is used by the SourceResolverImpl class to select
the SourcFactory to release() the Source to. Therefor is has to return
the component hint for the factory.
Was there some specific you needed this change for?
Unico
> -----Original Message-----
> From: unico@apache.org [mailto:unico@apache.org]
> Sent: dinsdag 17 februari 2004 18:19
> To: cocoon-2.1-cvs@apache.org
> Subject: cvs commit:
> cocoon-2.1/src/blocks/repository/java/org/apache/cocoon/compon
> ents/source/impl RepositorySourceFactory.java RepositorySource.java
>
> unico 2004/02/17 09:19:26
>
> Modified:
> src/blocks/repository/java/org/apache/cocoon/components/source/impl
> RepositorySourceFactory.java
> RepositorySource.java
> Log:
> support eventcaching;
>
> undo previous change in getScheme():
>
> unfortunately getScheme() *must* always return the factory name.
>
> This is because the source resolver selects the
> SourceFactory to release the
>
> source to based on that value...
>
> Revision Changes Path
> 1.4 +44 -4
> cocoon-2.1/src/blocks/repository/java/org/apache/cocoon/compon
> ents/source/impl/RepositorySourceFactory.java
>
<snip/>
> 1.5 +74 -38
> cocoon-2.1/src/blocks/repository/java/org/apache/cocoon/compon
> ents/source/impl/RepositorySource.java
>
> Index: RepositorySource.java
> ===================================================================
> RCS file:
> /home/cvs/cocoon-2.1/src/blocks/repository/java/org/apache/coc
> oon/components/source/impl/RepositorySource.java,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- RepositorySource.java 16 Feb 2004 16:03:09 -0000 1.4
> +++ RepositorySource.java 17 Feb 2004 17:19:26 -0000 1.5
<snip/>
> public String getScheme() {
> - return m_prefix + ":" + m_delegate.getScheme();
> + return m_prefix;
> }
>
<snip/>
Re: cvs commit: cocoon-2.1/src/blocks/repository/java/org/apache/cocoon/components/source/impl
RepositorySourceFactory.java RepositorySource.java
Posted by Gianugo Rabellino <gi...@apache.org>.
Unico Hommes wrote:
>
> Gianugo,
>
> Unfortunately I had to undo your previous change to the getScheme()
> method. This method is used by the SourceResolverImpl class to select
> the SourcFactory to release() the Source to. Therefor is has to return
> the component hint for the factory.
>
> Was there some specific you needed this change for?
Not really, I thought it was for consistence. I'm happy with getURI()
for now. :-)
Ciao,
--
Gianugo