[GitHub] [superset] eschutho commented on a diff in pull request #23004: fix: Datasource Url error

["eschutho (via GitHub)" <gi...@apache.org>]

eschutho commented on code in PR #23004:
URL: https://github.com/apache/superset/pull/23004#discussion_r1097957477


##########
superset/models/slice.py:
##########
@@ -164,7 +164,7 @@ def datasource_url(self) -> Optional[str]:
         if self.table:
             return self.table.explore_url
         datasource = self.datasource
-        return datasource.explore_url if datasource else None
+        return datasource.get("explore_url", None) if datasource else None

Review Comment:
   datasource is a class instance, not a dictionary, right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org