You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@qpid.apache.org by Ganesh Murthy <gm...@redhat.com> on 2019/08/29 14:43:19 UTC

[Qpid Dispatch Router] Question about qdstat default option

Hello All,
    As part of enhancement
https://issues.apache.org/jira/browse/DISPATCH-1374, executing qdsat with
no options would default to qdstat -g (--general).

Prior to this enhancement, running qdstat with no options would look like
this -

[gmurthy@localhost qpid-dispatch]$ qdstat
Usage: qdstat [options]

qdstat: error: You must specify one of these options: -g, -c, -l, -n, -a,
-m, -h, --autolinks, --linkroutes, or --log.

After this enhancement, running qdstat would look like this -

[gmurthy@localhost qpid-dispatch]$ qdstat
Router Statistics
  attr                             value
  =============================================================
  Version                          1.9.0-SNAPSHOT
  Mode                             standalone
  Router Id                        Standalone__VkGBH3CTsbo4Un
  Area                             0
  Link Routes                      0
  Auto Links                       0
  Links                            2
  Nodes                            0
  Addresses                        4
  Connections                      1
  Presettled Count                 0
  Dropped Presettled Count         0
  Accepted Count                   2
  Rejected Count                   0
  Released Count                   0
  Modified Count                   0
  Deliveries Delayed > 1sec        0
  Deliveries Delayed > 10sec       0
  Deliveries to Fallback           0
  Ingress Count                    2
  Egress Count                     1
  Transit Count                    0
  Deliveries from Route Container  0
  Deliveries to Route Container    0

Also, as part of this enhancement two new options --all-routers and
--all-entities were introduced.

When we run qdstat --all-routers, it by default runs qdstat --all-routers
--all-entities which will return all entities for every router in the
network.

Should executing qdstat --all-routers instead by default just return qdstat
--all-routers -g (return just the general info for all routers instead of
all information for all routers) ?

Please let me know what you think.

Thanks.

Re: [Qpid Dispatch Router] Question about qdstat default option

Posted by Ganesh Murthy <gm...@redhat.com>.
Thanks all for your feedback. I have checked in the changes to master
branch.

On Thu, Aug 29, 2019 at 1:26 PM Ken Giusti <kg...@redhat.com> wrote:

> +1 to implied -g and not implying "--all-entities" in the case of
> "--all-routers"  (or ever, for that matter).
>
> On Thu, Aug 29, 2019 at 11:22 AM Ted Ross <tr...@redhat.com> wrote:
>
> > On Thu, Aug 29, 2019 at 11:05 AM Gordon Sim <gs...@redhat.com> wrote:
> >
> > > On 29/08/2019 4:00 pm, Chuck Rolke wrote:
> > > > 1. A naked qdstat return "Router statistics" is a good idea.
> > > > A naked qdstat return an error is annoying.
> > > >
> > > > 2. The simple "--all-routers" returning "--all-routers
> --all-entities"
> > > is too much.
> > > > Changing "--all-routers" with no other switches to be "--all-routers
> > -g"
> > > is better.
> > > >
> > > > +1 to both suggestions.
> > >
> > > +1 on both from me also.
> > >
> >
> > Make that three.
> >
> > +1
> >
> >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> > > For additional commands, e-mail: users-help@qpid.apache.org
> > >
> > >
> >
>
>
> --
> -K
>

Re: [Qpid Dispatch Router] Question about qdstat default option

Posted by Ken Giusti <kg...@redhat.com>.
+1 to implied -g and not implying "--all-entities" in the case of
"--all-routers"  (or ever, for that matter).

On Thu, Aug 29, 2019 at 11:22 AM Ted Ross <tr...@redhat.com> wrote:

> On Thu, Aug 29, 2019 at 11:05 AM Gordon Sim <gs...@redhat.com> wrote:
>
> > On 29/08/2019 4:00 pm, Chuck Rolke wrote:
> > > 1. A naked qdstat return "Router statistics" is a good idea.
> > > A naked qdstat return an error is annoying.
> > >
> > > 2. The simple "--all-routers" returning "--all-routers --all-entities"
> > is too much.
> > > Changing "--all-routers" with no other switches to be "--all-routers
> -g"
> > is better.
> > >
> > > +1 to both suggestions.
> >
> > +1 on both from me also.
> >
>
> Make that three.
>
> +1
>
>
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> > For additional commands, e-mail: users-help@qpid.apache.org
> >
> >
>


-- 
-K

Re: [Qpid Dispatch Router] Question about qdstat default option

Posted by Ted Ross <tr...@redhat.com>.
On Thu, Aug 29, 2019 at 11:05 AM Gordon Sim <gs...@redhat.com> wrote:

> On 29/08/2019 4:00 pm, Chuck Rolke wrote:
> > 1. A naked qdstat return "Router statistics" is a good idea.
> > A naked qdstat return an error is annoying.
> >
> > 2. The simple "--all-routers" returning "--all-routers --all-entities"
> is too much.
> > Changing "--all-routers" with no other switches to be "--all-routers -g"
> is better.
> >
> > +1 to both suggestions.
>
> +1 on both from me also.
>

Make that three.

+1


> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
> For additional commands, e-mail: users-help@qpid.apache.org
>
>

Re: [Qpid Dispatch Router] Question about qdstat default option

Posted by Gordon Sim <gs...@redhat.com>.
On 29/08/2019 4:00 pm, Chuck Rolke wrote:
> 1. A naked qdstat return "Router statistics" is a good idea.
> A naked qdstat return an error is annoying.
> 
> 2. The simple "--all-routers" returning "--all-routers --all-entities" is too much.
> Changing "--all-routers" with no other switches to be "--all-routers -g" is better.
> 
> +1 to both suggestions.

+1 on both from me also.

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org


Re: [Qpid Dispatch Router] Question about qdstat default option

Posted by Chuck Rolke <cr...@redhat.com>.
1. A naked qdstat return "Router statistics" is a good idea. 
A naked qdstat return an error is annoying.

2. The simple "--all-routers" returning "--all-routers --all-entities" is too much.
Changing "--all-routers" with no other switches to be "--all-routers -g" is better.

+1 to both suggestions.


----- Original Message -----
> From: "Ganesh Murthy" <gm...@redhat.com>
> To: users@qpid.apache.org
> Sent: Thursday, August 29, 2019 10:43:19 AM
> Subject: [Qpid Dispatch Router] Question about qdstat default option
> 
> Hello All,
>     As part of enhancement
> https://issues.apache.org/jira/browse/DISPATCH-1374, executing qdsat with
> no options would default to qdstat -g (--general).
> 
> Prior to this enhancement, running qdstat with no options would look like
> this -
> 
> [gmurthy@localhost qpid-dispatch]$ qdstat
> Usage: qdstat [options]
> 
> qdstat: error: You must specify one of these options: -g, -c, -l, -n, -a,
> -m, -h, --autolinks, --linkroutes, or --log.
> 
> After this enhancement, running qdstat would look like this -
> 
> [gmurthy@localhost qpid-dispatch]$ qdstat
> Router Statistics
>   attr                             value
>   =============================================================
>   Version                          1.9.0-SNAPSHOT
>   Mode                             standalone
>   Router Id                        Standalone__VkGBH3CTsbo4Un
>   Area                             0
>   Link Routes                      0
>   Auto Links                       0
>   Links                            2
>   Nodes                            0
>   Addresses                        4
>   Connections                      1
>   Presettled Count                 0
>   Dropped Presettled Count         0
>   Accepted Count                   2
>   Rejected Count                   0
>   Released Count                   0
>   Modified Count                   0
>   Deliveries Delayed > 1sec        0
>   Deliveries Delayed > 10sec       0
>   Deliveries to Fallback           0
>   Ingress Count                    2
>   Egress Count                     1
>   Transit Count                    0
>   Deliveries from Route Container  0
>   Deliveries to Route Container    0
> 
> Also, as part of this enhancement two new options --all-routers and
> --all-entities were introduced.
> 
> When we run qdstat --all-routers, it by default runs qdstat --all-routers
> --all-entities which will return all entities for every router in the
> network.
> 
> Should executing qdstat --all-routers instead by default just return qdstat
> --all-routers -g (return just the general info for all routers instead of
> all information for all routers) ?
> 
> Please let me know what you think.
> 
> Thanks.
> 

---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@qpid.apache.org
For additional commands, e-mail: users-help@qpid.apache.org