You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "PickBas (via GitHub)" <gi...@apache.org> on 2023/05/22 11:30:13 UTC
[GitHub] [eventmesh] PickBas opened a new pull request, #4004: [ISSUE #3907] Method needlessly defines parameter with concrete classes[HttpTinyClient]
PickBas opened a new pull request, #4004:
URL: https://github.com/apache/eventmesh/pull/4004
Fixes #3907.
### Modifications
Replaced List with Collection
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #4004: [ISSUE #3907] Method needlessly defines parameter with concrete classes[HttpTinyClient]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4004:
URL: https://github.com/apache/eventmesh/pull/4004#issuecomment-1560542721
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4004?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4004](https://app.codecov.io/gh/apache/eventmesh/pull/4004?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (66ec7bd) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/1798e1f9b5cc212ec75425325bdfb3d1502a4ab5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (1798e1f) will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 66ec7bd differs from pull request most recent head bd7e238. Consider uploading reports for the commit bd7e238 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4004 +/- ##
============================================
- Coverage 14.24% 14.23% -0.02%
Complexity 1320 1320
============================================
Files 579 579
Lines 28958 28951 -7
Branches 2815 2801 -14
============================================
- Hits 4125 4121 -4
+ Misses 24441 24439 -2
+ Partials 392 391 -1
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/4004?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../apache/eventmesh/runtime/util/HttpTinyClient.java](https://app.codecov.io/gh/apache/eventmesh/pull/4004?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL3V0aWwvSHR0cFRpbnlDbGllbnQuamF2YQ==) | `89.28% <ø> (ø)` | |
... and [7 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4004/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 commented on pull request #4004: [ISSUE #3907] Method needlessly defines parameter with concrete classes[HttpTinyClient]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 commented on PR #4004:
URL: https://github.com/apache/eventmesh/pull/4004#issuecomment-1560375384
@PickBas you can fix the ci check error by merge the latest master branch code to your branch, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #4004: [ISSUE #3907] Method needlessly defines parameter with concrete classes[HttpTinyClient]
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #4004:
URL: https://github.com/apache/eventmesh/pull/4004
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org