You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "dipankr (via GitHub)" <gi...@apache.org> on 2023/04/13 02:49:50 UTC
[GitHub] [eventmesh] dipankr opened a new pull request, #3711: [ ISSUE #3652] refactored code
dipankr opened a new pull request, #3711:
URL: https://github.com/apache/eventmesh/pull/3711
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Fixes #3652.
### Motivation
*Explain the content here.*
*Explain why you want to make the changes and what problem you're trying to solve.*
there were duplicate code in the file, refactored the duplicate code to a method and refactored further to make the code more readable
### Modifications
refactored the code, extracted a new method and used switch to make code more readable
### Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] dipankr closed pull request #3711: [ ISSUE #3652] refactored code
Posted by "dipankr (via GitHub)" <gi...@apache.org>.
dipankr closed pull request #3711: [ ISSUE #3652] refactored code
URL: https://github.com/apache/eventmesh/pull/3711
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org