You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@groovy.apache.org by "Goooler (via GitHub)" <gi...@apache.org> on 2023/08/22 02:18:00 UTC
[GitHub] [groovy] Goooler opened a new pull request, #1935: Move JDK 18 into groovy-build-test-aux matrix
Goooler opened a new pull request, #1935:
URL: https://github.com/apache/groovy/pull/1935
Seems JDK 18 should be seated at `Build and test additional JDK versions`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] Goooler commented on pull request #1935: Move JDK 18 into groovy-build-test-aux matrix
Posted by "Goooler (via GitHub)" <gi...@apache.org>.
Goooler commented on PR #1935:
URL: https://github.com/apache/groovy/pull/1935#issuecomment-1713300129
Can we use squash commits for some PRs, is there any reason to use rebase only?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] Goooler merged pull request #1935: Move JDK 18 into groovy-build-test-aux matrix
Posted by "Goooler (via GitHub)" <gi...@apache.org>.
Goooler merged PR #1935:
URL: https://github.com/apache/groovy/pull/1935
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1935: Move JDK 18 into groovy-build-test-aux matrix
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert commented on PR #1935:
URL: https://github.com/apache/groovy/pull/1935#issuecomment-1713297490
+1, I think you have all the necessary permissions to merge yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] paulk-asert commented on pull request #1935: Move JDK 18 into groovy-build-test-aux matrix
Posted by "paulk-asert (via GitHub)" <gi...@apache.org>.
paulk-asert commented on PR #1935:
URL: https://github.com/apache/groovy/pull/1935#issuecomment-1713318263
Yes, we can certainly squash commits when it makes sense. In fact, it is often preferred - though if there are pieces of a PR which might be cherry-picked individually for backporting to branches, we often keep those separate.
We often don't need the commit history, so merge isn't usually needed and rebase suffices giving us a cleaner history (when it makes sense). Also, in the past, some tooling like `git bisect` seemed to get more confused from merges than rebases but I haven't tracked whether that has improved over the years.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [groovy] Goooler commented on pull request #1935: Move JDK 18 into groovy-build-test-aux matrix
Posted by "Goooler (via GitHub)" <gi...@apache.org>.
Goooler commented on PR #1935:
URL: https://github.com/apache/groovy/pull/1935#issuecomment-1713324298
Thanks for your explaination.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@groovy.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org