You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/08/21 01:19:15 UTC

[GitHub] [incubator-druid] mcbrewster commented on a change in pull request #8346: Web-console: fix alerts from lgtm

mcbrewster commented on a change in pull request #8346: Web-console: fix alerts from lgtm
URL: https://github.com/apache/incubator-druid/pull/8346#discussion_r315965696
 
 

 ##########
 File path: web-console/webpack.config.js
 ##########
 @@ -124,10 +124,8 @@ module.exports = env => {
       ],
     },
     performance: {
-      hints: false
+      hints: false,
     },
-    plugins: [
-      // new BundleAnalyzerPlugin()
-    ],
+    plugins: process.env.BUNDLE_ANALYZER_PLUGIN === 'TRUE' ? [new BundleAnalyzerPlugin()] : [],
 
 Review comment:
   @vogievetsky is this what you wanted? I documented it in both the build script and the read me

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org