You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/04/29 21:57:24 UTC

[GitHub] [hbase] joshelser opened a new pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

joshelser opened a new pull request #1609:
URL: https://github.com/apache/hbase/pull/1609


   On 2.x branches, we need to explicitly activate profiles for H3. On
   master, all H2 support is dropped which means no special profiles are
   required for H3 (though, there is still a profile there to encapsulate
   H3 logic).
   
   We need to make sure that the yetus invocation can correctly pass down
   any profile information into the personality, so we activate the exact
   profiles we want.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache9 commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621572542


   Seems not easy, maven does not allow multiple properties condition for activating a profile.
   
   There is a plugin
   
   https://github.com/kpiwko/el-profile-activator-extension
   
   but seems lack of support.
   
   So let's use hadoop.profile on branch-2.x first.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] joshelser commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621943030


   > Seems not easy, maven does not allow multiple properties condition for activating a profile.
   
   Yeah, huge pain in the butt.
   
   > In general, I think we should test for branch-2.x, not for master, as we need to deal with feature branches.
   
   Sure, fine to flip-flop this. Let me try to do it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] joshelser commented on a change in pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
joshelser commented on a change in pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#discussion_r418128491



##########
File path: dev-support/hbase-personality.sh
##########
@@ -146,7 +146,7 @@ function personality_modules
   fi
 
   if [[ -n "${HADOOP_PROFILE}" ]]; then
-    extra="${extra} -Phadoop-${HADOOP_PROFILE}"
+    extra="${extra} -Dhadoop.profile=${HADOOP_PROFILE}"

Review comment:
       My assumption was that we could do this when we invoke yetus and then not have to sully the personality itself.
   
   I guess there is an expectation that people can invoke yetus by hand, too. Makes me wonder if it's easier to just do it all in the personality then.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621969493


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 34s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  3s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 11s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   3m  2s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/3/artifact/yetus-jdk8-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1609 |
   | Optional Tests |  |
   | uname | Linux ca82a7814789 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 512d00e75d |
   | Max. process+thread count | 48 (vs. ulimit of 12500) |
   | modules | C:  U:  |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/3/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] joshelser commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621966374


   7fd06f7 switches from checking for "not master to checking for "branch-2*". Also pushes the logic down into the personality (not just in the invocation of yetus) to try to keep developer invocation of yetus working.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621490812






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621491032


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 40s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 36s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  2s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  0s |  ASF License check generated no output?  |
   |  |   |   2m 33s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/1/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1609 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux dd017919c556 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / e3c5527ce5 |
   | Max. process+thread count | 52 (vs. ulimit of 12500) |
   | modules | C:  U:  |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/1/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621490266






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621968791


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 30s |  Docker mode activated.  |
   | -0 :warning: |  yetus  |   0m  4s |  Unprocessed flag(s): --brief-report-file --spotbugs-strict-precheck --whitespace-eol-ignore-list --whitespace-tabs-ignore-list --quick-hadoopcheck  |
   ||| _ Prechecks _ |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 18s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   ||| _ Other Tests _ |
   |  |   |   1m 52s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/3/artifact/yetus-jdk11-hadoop3-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1609 |
   | Optional Tests |  |
   | uname | Linux 4e9444e3c57c 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 512d00e75d |
   | Max. process+thread count | 47 (vs. ulimit of 12500) |
   | modules | C:  U:  |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/3/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621494084






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621968210


   (!) A patch to the testing environment has been detected. 
   Re-executing against the patched versions to perform further tests. 
   The console is at https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/3/console in case of problems.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621968340






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache9 commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621563037


   This was what I want to do at the first place when removing the hadoop 2 support for master but then I found that using -P is simpler here. So please hold on and let me try to find out why this does not work on branch-2.3 before merging the patch here. If I fail then let's apply this PR.
   
   Thanks.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621969743


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   1m 29s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +0 :ok: |  shelldocs  |   0m  1s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 35s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  3s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  0s |  ASF License check generated no output?  |
   |  |   |   3m 29s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/3/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1609 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux 0b077318469d 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / 512d00e75d |
   | Max. process+thread count | 52 (vs. ulimit of 12500) |
   | modules | C:  U:  |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/3/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache9 commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache9 commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-622775512


   Be lated +1.
   
   Thanks @joshelser  for taking care of this.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache9 commented on a change in pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache9 commented on a change in pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#discussion_r417717780



##########
File path: dev-support/hbase-personality.sh
##########
@@ -459,7 +459,7 @@ function shadedjars_rebuild
     '-Dtest=NoUnitTests' '-DHBasePatchProcess' '-Prelease'
     '-Dmaven.javadoc.skip=true' '-Dcheckstyle.skip=true' '-Dspotbugs.skip=true')
   if [[ -n "${HADOOP_PROFILE}" ]]; then
-    maven_args+=("-Phadoop-${HADOOP_PROFILE}")
+    maven_args+=("-Dhadoop.profile=${HADOOP_PROFILE}")

Review comment:
       Ditto.

##########
File path: dev-support/hbase-personality.sh
##########
@@ -146,7 +146,7 @@ function personality_modules
   fi
 
   if [[ -n "${HADOOP_PROFILE}" ]]; then
-    extra="${extra} -Phadoop-${HADOOP_PROFILE}"
+    extra="${extra} -Dhadoop.profile=${HADOOP_PROFILE}"

Review comment:
       Also need the branch check here.

##########
File path: dev-support/hbase-personality.sh
##########
@@ -644,7 +644,7 @@ function hadoopcheck_rebuild
       $(maven_executor) clean install \
         -DskipTests -DHBasePatchProcess \
         -Dhadoop-three.version="${hadoopver}" \
-        -Phadoop-3.0
+        -Dhadoop.profile="3.0"

Review comment:
       Ditto.

##########
File path: dev-support/hbase_nightly_yetus.sh
##########
@@ -76,7 +76,11 @@ fi
 
 # For testing with specific hadoop version. Activates corresponding profile in maven runs.
 if [[ -n "${HADOOP_PROFILE}" ]]; then
-  YETUS_ARGS=("--hadoop-profile=${HADOOP_PROFILE}" "${YETUS_ARGS[@]}")
+  # Master has only Hadoop3 support. We don't need to activate any profile.
+  # The Jenkinsfile should not attempt to run any Hadoop2 tests.
+  if [[ "${BRANCH_NAME}" != "master" ]]; then

Review comment:
       I think here we should test for branch-2.x, not for !master, as feature branches should use the same solution with master.

##########
File path: dev-support/jenkins_precommit_github_yetus.sh
##########
@@ -127,7 +127,11 @@ YETUS_ARGS+=("--skip-errorprone")
 YETUS_ARGS+=("--skip-dirs=dev-support")
 # For testing with specific hadoop version. Activates corresponding profile in maven runs.
 if [[ -n "${HADOOP_PROFILE}" ]]; then
-  YETUS_ARGS+=("--hadoop-profile=${HADOOP_PROFILE}")
+  # Master has only Hadoop3 support. We don't need to activate any profile.
+  # The Jenkinsfile should not attempt to run any Hadoop2 tests.
+  if [[ "${BRANCH_NAME}" != "master" ]]; then

Review comment:
       Ditto.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621494777


   :confetti_ball: **+1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 39s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  0s |  No case conflicting files found.  |
   | +0 :ok: |  shelldocs  |   0m  0s |  Shelldocs was not available.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any @author tags.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 33s |  Maven dependency ordering for branch  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 10s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  shellcheck  |   0m  3s |  There were no new shellcheck issues.  |
   | +1 :green_heart: |  whitespace  |   0m  0s |  The patch has no whitespace issues.  |
   ||| _ Other Tests _ |
   | +0 :ok: |  asflicense  |   0m  0s |  ASF License check generated no output?  |
   |  |   |   2m 13s |   |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.8 Server=19.03.8 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/2/artifact/yetus-general-check/output/Dockerfile |
   | GITHUB PR | https://github.com/apache/hbase/pull/1609 |
   | Optional Tests | dupname asflicense shellcheck shelldocs |
   | uname | Linux 64b5e78625ef 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | dev-support/hbase-personality.sh |
   | git revision | master / e3c5527ce5 |
   | Max. process+thread count | 52 (vs. ulimit of 12500) |
   | modules | C:  U:  |
   | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-1609/2/console |
   | versions | git=2.17.1 maven=(cecedd343002696d0abb50b32b541b8a6ba2883f) shellcheck=0.4.6 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] Apache-HBase commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
Apache-HBase commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-621494439






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [hbase] joshelser commented on pull request #1609: HBASE-24280 No explicit Hadoop3 profile activation on master

Posted by GitBox <gi...@apache.org>.
joshelser commented on pull request #1609:
URL: https://github.com/apache/hbase/pull/1609#issuecomment-622586175


   Thanks Stack. Let me bring this in.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org