You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "zuston (via GitHub)" <gi...@apache.org> on 2023/11/03 07:05:46 UTC
[PR] [#1294] feat(rust): introduce the unified grpc latency metrics for all requests [incubator-uniffle]
zuston opened a new pull request, #1295:
URL: https://github.com/apache/incubator-uniffle/pull/1295
### What changes were proposed in this pull request?
introduce the unified grpc latency metrics for all requests
### Why are the changes needed?
For #1294
Currently, we calculate the request duration for every request in the service codebase,
which is ugly and scattered everywhere.
BTW, the current request duration metrics is limited to critical paths.
So, it's necessary to use the tonic's layer mechanism to summary the grpc latency metrics.
And the reason of no deleting original latency metrics is the difference of each other,
the metrics embedded in the layer will be greater than in the service code,
because request will spend sometime to decoding the message, the diff time is valuable for observability.
### Does this PR introduce _any_ user-facing change?
Yes. After applying this patch, the latency metrics of request like P99 could be gotten like this.
`histogram_quantile(0.99, sum(rate(grpc_duration_seconds_bucket{path="/rss.common.ShuffleServer/sendShuffleData", job="uniffle-worker"}[2m])) by (le))`
### How was this patch tested?
Tested in the test env and validated by the promql
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1294] feat(rust): introduce the unified grpc latency metrics for all requests [incubator-uniffle]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #1295:
URL: https://github.com/apache/incubator-uniffle/pull/1295#issuecomment-1791974851
## [Codecov](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1295?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#1295](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1295?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (232ae73) into [master](https://app.codecov.io/gh/apache/incubator-uniffle/commit/adafac4dad84da6470c7707576ba3b85b1f301a8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (adafac4) will **increase** coverage by `1.30%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #1295 +/- ##
============================================
+ Coverage 53.67% 54.97% +1.30%
+ Complexity 2690 2551 -139
============================================
Files 403 370 -33
Lines 23456 19657 -3799
Branches 1992 1862 -130
============================================
- Hits 12589 10807 -1782
+ Misses 10093 8181 -1912
+ Partials 774 669 -105
```
[see 35 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-uniffle/pull/1295/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in [Chrome](https://chrome.google.com/webstore/detail/codecov/gedikamndpbemklijjkncpnolildpbgo) or [Firefox](https://addons.mozilla.org/en-US/firefox/addon/codecov/) today!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1294] feat(rust): introduce the unified grpc latency metrics for all requests [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston merged PR #1295:
URL: https://github.com/apache/incubator-uniffle/pull/1295
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
Re: [PR] [#1294] feat(rust): introduce the unified grpc latency metrics for all requests [incubator-uniffle]
Posted by "zuston (via GitHub)" <gi...@apache.org>.
zuston commented on PR #1295:
URL: https://github.com/apache/incubator-uniffle/pull/1295#issuecomment-1791969022
@jerqi Please help review this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org