You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "Abhitocode (via GitHub)" <gi...@apache.org> on 2024/08/01 04:06:23 UTC
[PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Abhitocode opened a new pull request, #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597
n addition to previous changes associated,
Migrated tests within DataTest.Java
The test can be identified by referring to CompensationTest.java:
https://github.com/apache/incubator-kie-kogito-runtimes/blob/main/jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java
Closes https://github.com/apache/incubator-kie-issues/issues/1131.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1701549535
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -166,311 +200,281 @@ public void testXpathExpression() throws Exception {
@Test
public void testDataInputAssociations() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociations.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello world");
- }
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello world");
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociations", params);
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
+ org.kie.kogito.process.Process<DataInputAssociationsModel> processDefinition = DataInputAssociationsProcess.newProcess(app);
+ DataInputAssociationsModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithStringObject() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsStringObject.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
-
- });
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", "hello");
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsStringObject", params);
-
+ public void testDataInputAssociationsWithStringObject() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
+
+ org.kie.kogito.process.Process<DataInputAssociationsStringObjectModel> processDefinition = DataInputAssociationsStringObjectProcess.newProcess(app);
+ DataInputAssociationsStringObjectModel model = processDefinition.createModel();
+ model.setInstanceMetadata("hello");
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringObjectModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
/**
* TODO testDataInputAssociationsWithLazyLoading
*/
@Test
- @Disabled
- public void testDataInputAssociationsWithLazyLoading()
- throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsLazyCreating.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- Element coIdParamObj = (Element) workItem.getParameter("coId");
- assertThat(coIdParamObj.getNodeName()).isEqualTo("mydoc");
- assertThat(coIdParamObj.getFirstChild().getNodeName()).isEqualTo("mynode");
- assertThat(coIdParamObj.getFirstChild().getFirstChild().getNodeName()).isEqualTo("user");
- assertThat(coIdParamObj.getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue()).isEqualTo("hello world");
- }
-
- });
+ public void testDataInputAssociationsWithLazyLoading() throws Exception {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ Element coIdParamObj = (Element) workItem.getParameter("coId");
+ assertThat(coIdParamObj.getNodeName()).isEqualTo("mydoc");
+ assertThat(coIdParamObj.getFirstChild().getNodeName()).isEqualTo("mynode");
+ assertThat(coIdParamObj.getFirstChild().getFirstChild().getNodeName()).isEqualTo("user");
+ assertThat(coIdParamObj.getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue()).isEqualTo("hello world");
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
Map<String, Object> params = new HashMap<>();
params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsLazyCreating", params);
+ org.kie.kogito.process.Process<DataInputAssociationsLazyCreatingModel> processDefinition = DataInputAssociationsLazyCreatingProcess.newProcess(app);
+ DataInputAssociationsLazyCreatingModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsLazyCreatingModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithString() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsString.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
+ public void testDataInputAssociationsWithString() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
- });
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsString");
+ org.kie.kogito.process.Process<DataInputAssociationsStringModel> processDefinition = DataInputAssociationsStringProcess.newProcess(app);
+ DataInputAssociationsStringModel model = processDefinition.createModel();
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithStringWithoutQuotes()
- throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsStringNoQuotes.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
+ public void testDataInputAssociationsWithStringWithoutQuotes() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
- });
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsStringNoQuotes");
+ org.kie.kogito.process.Process<DataInputAssociationsStringNoQuotesModel> processDefinition = DataInputAssociationsStringNoQuotesProcess.newProcess(app);
+ DataInputAssociationsStringNoQuotesModel model = processDefinition.createModel();
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringNoQuotesModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithXMLLiteral() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsXmlLiteral.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getNodeName()).isEqualTo("id");
- assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getFirstChild().getTextContent()).isEqualTo("some text");
- }
-
- });
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsXmlLiteral");
-
+ public void testDataInputAssociationsWithXMLLiteral() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getNodeName()).isEqualTo("id");
+ assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getFirstChild().getTextContent()).isEqualTo("some text");
+ }
+ });
+
+ org.kie.kogito.process.Process<DataInputAssociationsXmlLiteralModel> processDefinition = DataInputAssociationsXmlLiteralProcess.newProcess(app);
+ DataInputAssociationsXmlLiteralModel model = processDefinition.createModel();
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsXmlLiteralModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
/**
* TODO testDataInputAssociationsWithTwoAssigns
*/
@Test
- @Disabled
public void testDataInputAssociationsWithTwoAssigns() throws Exception {
- kruntime = createKogitoProcessRuntime("BPMN2-DataInputAssociations-two-assigns.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
- // assertEquals("mynode", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getNodeName());
- // assertEquals("user", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
- // assertEquals("hello world", ((Element)
- // workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
- }
-
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
+ // assertEquals("mynode", ((Element) workItem.getParameter("Comment")).getFirstChild().getNodeName());
+ // assertEquals("user", ((Element) workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
+ // assertEquals("hello world", ((Element) workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
Review Comment:
did you find out why are they commented ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on code in PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1700836888
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -325,152 +355,129 @@ public void executeWorkItem(KogitoWorkItem workItem,
@Test
@Disabled
public void testDataInputAssociationsWithTwoAssigns() throws Exception {
- kruntime = createKogitoProcessRuntime("BPMN2-DataInputAssociations-two-assigns.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
- // assertEquals("mynode", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getNodeName());
- // assertEquals("user", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
- // assertEquals("hello world", ((Element)
- // workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
- }
-
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
+ // assertEquals("mynode", ((Element) workItem.getParameter("Comment")).getFirstChild().getNodeName());
+ // assertEquals("user", ((Element) workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
+ // assertEquals("hello world", ((Element) workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("process",
- params);
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
+
+ org.kie.kogito.process.Process<DataInputAssociationsTwoAssignsModel> processDefinition = DataInputAssociationsTwoAssignsProcess.newProcess(app);
+ DataInputAssociationsTwoAssignsModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsTwoAssignsModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataOutputAssociationsforHumanTask() throws Exception {
+ public void testDataOutputAssociationsforHumanTask() {
Application app = ProcessTestHelper.newApplication();
- ProcessTestHelper.registerHandler(app, "Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- DocumentBuilderFactory factory = DocumentBuilderFactory
- .newInstance();
- DocumentBuilder builder;
- try {
- builder = factory.newDocumentBuilder();
- } catch (ParserConfigurationException e) {
- throw new RuntimeException(e);
- }
- final Map<String, Object> results = new HashMap<>();
-
- // process metadata
- org.w3c.dom.Document processMetadaDoc = builder
- .newDocument();
- org.w3c.dom.Element processMetadata = processMetadaDoc
- .createElement("previoustasksowner");
- processMetadaDoc.appendChild(processMetadata);
- // org.w3c.dom.Element procElement =
- // processMetadaDoc.createElement("previoustasksowner");
- processMetadata
- .setAttribute("primaryname", "my_result");
- // processMetadata.appendChild(procElement);
- results.put("output", processMetadata);
-
- mgr.completeWorkItem(workItem.getStringId(), results);
- }
-
- });
-
- org.kie.kogito.process.Process<DataOutputAssociationsHumanTaskModel> definition = DataOutputAssociationsHumanTaskProcess.newProcess(app);
- org.kie.kogito.process.ProcessInstance<DataOutputAssociationsHumanTaskModel> instance = definition.createInstance(definition.createModel());
-
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
+ DocumentBuilder builder;
+ try {
+ builder = factory.newDocumentBuilder();
+ } catch (ParserConfigurationException e) {
+ throw new RuntimeException(e);
+ }
+ final Map<String, Object> results = new HashMap<>();
+ // process metadata
+ org.w3c.dom.Document processMetadaDoc = builder.newDocument();
+ org.w3c.dom.Element processMetadata = processMetadaDoc.createElement("previoustasksowner");
+ processMetadaDoc.appendChild(processMetadata);
+ processMetadata.setAttribute("primaryname", "my_result");
+ results.put("output", processMetadata);
+ mgr.completeWorkItem(workItem.getStringId(), results);
+ }
+ });
+
+ org.kie.kogito.process.Process<DataOutputAssociationsHumanTaskModel> processDefinition = DataOutputAssociationsHumanTaskProcess.newProcess(app);
+ DataOutputAssociationsHumanTaskModel model = processDefinition.createModel();
+
+ org.kie.kogito.process.ProcessInstance<DataOutputAssociationsHumanTaskModel> instance = processDefinition.createInstance(model);
instance.start();
}
Review Comment:
Observed the same in case of assert, sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1701554004
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -325,152 +355,129 @@ public void executeWorkItem(KogitoWorkItem workItem,
@Test
@Disabled
public void testDataInputAssociationsWithTwoAssigns() throws Exception {
- kruntime = createKogitoProcessRuntime("BPMN2-DataInputAssociations-two-assigns.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
- // assertEquals("mynode", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getNodeName());
- // assertEquals("user", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
- // assertEquals("hello world", ((Element)
- // workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
- }
-
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
+ // assertEquals("mynode", ((Element) workItem.getParameter("Comment")).getFirstChild().getNodeName());
+ // assertEquals("user", ((Element) workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
+ // assertEquals("hello world", ((Element) workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("process",
- params);
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
+
+ org.kie.kogito.process.Process<DataInputAssociationsTwoAssignsModel> processDefinition = DataInputAssociationsTwoAssignsProcess.newProcess(app);
+ DataInputAssociationsTwoAssignsModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsTwoAssignsModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataOutputAssociationsforHumanTask() throws Exception {
+ public void testDataOutputAssociationsforHumanTask() {
Application app = ProcessTestHelper.newApplication();
- ProcessTestHelper.registerHandler(app, "Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- DocumentBuilderFactory factory = DocumentBuilderFactory
- .newInstance();
- DocumentBuilder builder;
- try {
- builder = factory.newDocumentBuilder();
- } catch (ParserConfigurationException e) {
- throw new RuntimeException(e);
- }
- final Map<String, Object> results = new HashMap<>();
-
- // process metadata
- org.w3c.dom.Document processMetadaDoc = builder
- .newDocument();
- org.w3c.dom.Element processMetadata = processMetadaDoc
- .createElement("previoustasksowner");
- processMetadaDoc.appendChild(processMetadata);
- // org.w3c.dom.Element procElement =
- // processMetadaDoc.createElement("previoustasksowner");
- processMetadata
- .setAttribute("primaryname", "my_result");
- // processMetadata.appendChild(procElement);
- results.put("output", processMetadata);
-
- mgr.completeWorkItem(workItem.getStringId(), results);
- }
-
- });
-
- org.kie.kogito.process.Process<DataOutputAssociationsHumanTaskModel> definition = DataOutputAssociationsHumanTaskProcess.newProcess(app);
- org.kie.kogito.process.ProcessInstance<DataOutputAssociationsHumanTaskModel> instance = definition.createInstance(definition.createModel());
-
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
+ DocumentBuilder builder;
+ try {
+ builder = factory.newDocumentBuilder();
+ } catch (ParserConfigurationException e) {
+ throw new RuntimeException(e);
+ }
+ final Map<String, Object> results = new HashMap<>();
+ // process metadata
+ org.w3c.dom.Document processMetadaDoc = builder.newDocument();
+ org.w3c.dom.Element processMetadata = processMetadaDoc.createElement("previoustasksowner");
+ processMetadaDoc.appendChild(processMetadata);
+ processMetadata.setAttribute("primaryname", "my_result");
+ results.put("output", processMetadata);
+ mgr.completeWorkItem(workItem.getStringId(), results);
+ }
+ });
+
+ org.kie.kogito.process.Process<DataOutputAssociationsHumanTaskModel> processDefinition = DataOutputAssociationsHumanTaskProcess.newProcess(app);
+ DataOutputAssociationsHumanTaskModel model = processDefinition.createModel();
+
+ org.kie.kogito.process.ProcessInstance<DataOutputAssociationsHumanTaskModel> instance = processDefinition.createInstance(model);
instance.start();
}
Review Comment:
In thjeory there is a previoustasksowner var in the process varariables. The assignment is like this:
`humanTaskNode_BF09B923_BE11_4447_BECB_609BD86C59EF.mapDataOutputAssociation(new org.jbpm.workflow.core.impl.DataAssociation(java.util.Arrays.asList(new org.jbpm.workflow.core.impl.DataDefinition("_BF09B923-BE11-4447-BECB-609BD86C59EF_PreviousOwner", "output", "java.lang.Object", null)), new org.jbpm.workflow.core.impl.DataDefinition("instanceMetadata", "instanceMetadata", "org.w3c.dom.Element", null), java.util.Arrays.asList(new org.jbpm.workflow.core.node.Assignment(null, new org.jbpm.workflow.core.impl.DataDefinition("bcea9e23-85fa-483a-88dc-5805aabdc19c", "EXPRESSION (@primaryname)", "java.lang.Object", "@primaryname"), new org.jbpm.workflow.core.impl.DataDefinition("ec810f97-9f2a-402a-b910-bae81d1a069d", "EXPRESSION (previoustasksowner)", "java.lang.Object", "previoustasksowner"))), null));`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on code in PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1701556013
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -325,152 +355,129 @@ public void executeWorkItem(KogitoWorkItem workItem,
@Test
@Disabled
public void testDataInputAssociationsWithTwoAssigns() throws Exception {
- kruntime = createKogitoProcessRuntime("BPMN2-DataInputAssociations-two-assigns.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
- // assertEquals("mynode", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getNodeName());
- // assertEquals("user", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
- // assertEquals("hello world", ((Element)
- // workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
- }
-
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
+ // assertEquals("mynode", ((Element) workItem.getParameter("Comment")).getFirstChild().getNodeName());
+ // assertEquals("user", ((Element) workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
+ // assertEquals("hello world", ((Element) workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("process",
- params);
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
+
+ org.kie.kogito.process.Process<DataInputAssociationsTwoAssignsModel> processDefinition = DataInputAssociationsTwoAssignsProcess.newProcess(app);
+ DataInputAssociationsTwoAssignsModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsTwoAssignsModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataOutputAssociationsforHumanTask() throws Exception {
+ public void testDataOutputAssociationsforHumanTask() {
Application app = ProcessTestHelper.newApplication();
- ProcessTestHelper.registerHandler(app, "Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- DocumentBuilderFactory factory = DocumentBuilderFactory
- .newInstance();
- DocumentBuilder builder;
- try {
- builder = factory.newDocumentBuilder();
- } catch (ParserConfigurationException e) {
- throw new RuntimeException(e);
- }
- final Map<String, Object> results = new HashMap<>();
-
- // process metadata
- org.w3c.dom.Document processMetadaDoc = builder
- .newDocument();
- org.w3c.dom.Element processMetadata = processMetadaDoc
- .createElement("previoustasksowner");
- processMetadaDoc.appendChild(processMetadata);
- // org.w3c.dom.Element procElement =
- // processMetadaDoc.createElement("previoustasksowner");
- processMetadata
- .setAttribute("primaryname", "my_result");
- // processMetadata.appendChild(procElement);
- results.put("output", processMetadata);
-
- mgr.completeWorkItem(workItem.getStringId(), results);
- }
-
- });
-
- org.kie.kogito.process.Process<DataOutputAssociationsHumanTaskModel> definition = DataOutputAssociationsHumanTaskProcess.newProcess(app);
- org.kie.kogito.process.ProcessInstance<DataOutputAssociationsHumanTaskModel> instance = definition.createInstance(definition.createModel());
-
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
+ DocumentBuilder builder;
+ try {
+ builder = factory.newDocumentBuilder();
+ } catch (ParserConfigurationException e) {
+ throw new RuntimeException(e);
+ }
+ final Map<String, Object> results = new HashMap<>();
+ // process metadata
+ org.w3c.dom.Document processMetadaDoc = builder.newDocument();
+ org.w3c.dom.Element processMetadata = processMetadaDoc.createElement("previoustasksowner");
+ processMetadaDoc.appendChild(processMetadata);
+ processMetadata.setAttribute("primaryname", "my_result");
+ results.put("output", processMetadata);
+ mgr.completeWorkItem(workItem.getStringId(), results);
+ }
+ });
+
+ org.kie.kogito.process.Process<DataOutputAssociationsHumanTaskModel> processDefinition = DataOutputAssociationsHumanTaskProcess.newProcess(app);
+ DataOutputAssociationsHumanTaskModel model = processDefinition.createModel();
+
+ org.kie.kogito.process.ProcessInstance<DataOutputAssociationsHumanTaskModel> instance = processDefinition.createInstance(model);
instance.start();
}
Review Comment:
same for the next two tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on code in PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1701976982
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -166,311 +200,281 @@ public void testXpathExpression() throws Exception {
@Test
public void testDataInputAssociations() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociations.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello world");
- }
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello world");
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociations", params);
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
+ org.kie.kogito.process.Process<DataInputAssociationsModel> processDefinition = DataInputAssociationsProcess.newProcess(app);
+ DataInputAssociationsModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithStringObject() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsStringObject.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
-
- });
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", "hello");
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsStringObject", params);
-
+ public void testDataInputAssociationsWithStringObject() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
+
+ org.kie.kogito.process.Process<DataInputAssociationsStringObjectModel> processDefinition = DataInputAssociationsStringObjectProcess.newProcess(app);
+ DataInputAssociationsStringObjectModel model = processDefinition.createModel();
+ model.setInstanceMetadata("hello");
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringObjectModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
/**
* TODO testDataInputAssociationsWithLazyLoading
*/
@Test
- @Disabled
- public void testDataInputAssociationsWithLazyLoading()
- throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsLazyCreating.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- Element coIdParamObj = (Element) workItem.getParameter("coId");
- assertThat(coIdParamObj.getNodeName()).isEqualTo("mydoc");
- assertThat(coIdParamObj.getFirstChild().getNodeName()).isEqualTo("mynode");
- assertThat(coIdParamObj.getFirstChild().getFirstChild().getNodeName()).isEqualTo("user");
- assertThat(coIdParamObj.getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue()).isEqualTo("hello world");
- }
-
- });
+ public void testDataInputAssociationsWithLazyLoading() throws Exception {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ Element coIdParamObj = (Element) workItem.getParameter("coId");
+ assertThat(coIdParamObj.getNodeName()).isEqualTo("mydoc");
+ assertThat(coIdParamObj.getFirstChild().getNodeName()).isEqualTo("mynode");
+ assertThat(coIdParamObj.getFirstChild().getFirstChild().getNodeName()).isEqualTo("user");
+ assertThat(coIdParamObj.getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue()).isEqualTo("hello world");
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
Map<String, Object> params = new HashMap<>();
params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsLazyCreating", params);
+ org.kie.kogito.process.Process<DataInputAssociationsLazyCreatingModel> processDefinition = DataInputAssociationsLazyCreatingProcess.newProcess(app);
+ DataInputAssociationsLazyCreatingModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsLazyCreatingModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithString() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsString.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
+ public void testDataInputAssociationsWithString() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
- });
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsString");
+ org.kie.kogito.process.Process<DataInputAssociationsStringModel> processDefinition = DataInputAssociationsStringProcess.newProcess(app);
+ DataInputAssociationsStringModel model = processDefinition.createModel();
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithStringWithoutQuotes()
- throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsStringNoQuotes.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
+ public void testDataInputAssociationsWithStringWithoutQuotes() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
- });
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsStringNoQuotes");
+ org.kie.kogito.process.Process<DataInputAssociationsStringNoQuotesModel> processDefinition = DataInputAssociationsStringNoQuotesProcess.newProcess(app);
+ DataInputAssociationsStringNoQuotesModel model = processDefinition.createModel();
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringNoQuotesModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithXMLLiteral() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsXmlLiteral.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getNodeName()).isEqualTo("id");
- assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getFirstChild().getTextContent()).isEqualTo("some text");
- }
-
- });
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsXmlLiteral");
-
+ public void testDataInputAssociationsWithXMLLiteral() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getNodeName()).isEqualTo("id");
+ assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getFirstChild().getTextContent()).isEqualTo("some text");
+ }
+ });
+
+ org.kie.kogito.process.Process<DataInputAssociationsXmlLiteralModel> processDefinition = DataInputAssociationsXmlLiteralProcess.newProcess(app);
+ DataInputAssociationsXmlLiteralModel model = processDefinition.createModel();
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsXmlLiteralModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
/**
* TODO testDataInputAssociationsWithTwoAssigns
*/
@Test
- @Disabled
public void testDataInputAssociationsWithTwoAssigns() throws Exception {
- kruntime = createKogitoProcessRuntime("BPMN2-DataInputAssociations-two-assigns.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
- // assertEquals("mynode", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getNodeName());
- // assertEquals("user", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
- // assertEquals("hello world", ((Element)
- // workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
- }
-
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
+ // assertEquals("mynode", ((Element) workItem.getParameter("Comment")).getFirstChild().getNodeName());
+ // assertEquals("user", ((Element) workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
+ // assertEquals("hello world", ((Element) workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
Review Comment:
the tests passes though uncommented but might be commented as invoking .getNodeName() on null leads to npe.
[INFO] Running org.jbpm.bpmn2.DataTest
org.jbpm.workflow.instance.WorkflowRuntimeException: [DataInputAssociationsTwoAssigns:b065ee88-e816-4dab-
F]] -- Cannot invoke "org.w3c.dom.Element.getNodeName()" because the return value of "org.kie.kogito.internal.process.runtime.KogitoWorkItem.getParameter(String)" is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "martinweiler (via GitHub)" <gi...@apache.org>.
martinweiler commented on code in PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1700782397
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -166,157 +201,152 @@ public void testXpathExpression() throws Exception {
@Test
public void testDataInputAssociations() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociations.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello world");
- }
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello world");
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociations", params);
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
+ org.kie.kogito.process.Process<DataInputAssociationsModel> processDefinition = DataInputAssociationsProcess.newProcess(app);
+ DataInputAssociationsModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithStringObject() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsStringObject.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
-
- });
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", "hello");
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsStringObject", params);
-
+ public void testDataInputAssociationsWithStringObject() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
+
+ org.kie.kogito.process.Process<DataInputAssociationsStringObjectModel> processDefinition = DataInputAssociationsStringObjectProcess.newProcess(app);
+ DataInputAssociationsStringObjectModel model = processDefinition.createModel();
+ model.setInstanceMetadata("hello");
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringObjectModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
/**
* TODO testDataInputAssociationsWithLazyLoading
*/
@Test
@Disabled
Review Comment:
We should try to make the disabled tests work. If there is a functional gap, then this should be captured in JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian merged PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "martinweiler (via GitHub)" <gi...@apache.org>.
martinweiler commented on code in PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1700792719
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -325,152 +355,129 @@ public void executeWorkItem(KogitoWorkItem workItem,
@Test
@Disabled
public void testDataInputAssociationsWithTwoAssigns() throws Exception {
- kruntime = createKogitoProcessRuntime("BPMN2-DataInputAssociations-two-assigns.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
- // assertEquals("mynode", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getNodeName());
- // assertEquals("user", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
- // assertEquals("hello world", ((Element)
- // workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
- }
-
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
+ // assertEquals("mynode", ((Element) workItem.getParameter("Comment")).getFirstChild().getNodeName());
+ // assertEquals("user", ((Element) workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
+ // assertEquals("hello world", ((Element) workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("process",
- params);
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
+
+ org.kie.kogito.process.Process<DataInputAssociationsTwoAssignsModel> processDefinition = DataInputAssociationsTwoAssignsProcess.newProcess(app);
+ DataInputAssociationsTwoAssignsModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsTwoAssignsModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataOutputAssociationsforHumanTask() throws Exception {
+ public void testDataOutputAssociationsforHumanTask() {
Application app = ProcessTestHelper.newApplication();
- ProcessTestHelper.registerHandler(app, "Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- DocumentBuilderFactory factory = DocumentBuilderFactory
- .newInstance();
- DocumentBuilder builder;
- try {
- builder = factory.newDocumentBuilder();
- } catch (ParserConfigurationException e) {
- throw new RuntimeException(e);
- }
- final Map<String, Object> results = new HashMap<>();
-
- // process metadata
- org.w3c.dom.Document processMetadaDoc = builder
- .newDocument();
- org.w3c.dom.Element processMetadata = processMetadaDoc
- .createElement("previoustasksowner");
- processMetadaDoc.appendChild(processMetadata);
- // org.w3c.dom.Element procElement =
- // processMetadaDoc.createElement("previoustasksowner");
- processMetadata
- .setAttribute("primaryname", "my_result");
- // processMetadata.appendChild(procElement);
- results.put("output", processMetadata);
-
- mgr.completeWorkItem(workItem.getStringId(), results);
- }
-
- });
-
- org.kie.kogito.process.Process<DataOutputAssociationsHumanTaskModel> definition = DataOutputAssociationsHumanTaskProcess.newProcess(app);
- org.kie.kogito.process.ProcessInstance<DataOutputAssociationsHumanTaskModel> instance = definition.createInstance(definition.createModel());
-
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ DocumentBuilderFactory factory = DocumentBuilderFactory.newInstance();
+ DocumentBuilder builder;
+ try {
+ builder = factory.newDocumentBuilder();
+ } catch (ParserConfigurationException e) {
+ throw new RuntimeException(e);
+ }
+ final Map<String, Object> results = new HashMap<>();
+ // process metadata
+ org.w3c.dom.Document processMetadaDoc = builder.newDocument();
+ org.w3c.dom.Element processMetadata = processMetadaDoc.createElement("previoustasksowner");
+ processMetadaDoc.appendChild(processMetadata);
+ processMetadata.setAttribute("primaryname", "my_result");
+ results.put("output", processMetadata);
+ mgr.completeWorkItem(workItem.getStringId(), results);
+ }
+ });
+
+ org.kie.kogito.process.Process<DataOutputAssociationsHumanTaskModel> processDefinition = DataOutputAssociationsHumanTaskProcess.newProcess(app);
+ DataOutputAssociationsHumanTaskModel model = processDefinition.createModel();
+
+ org.kie.kogito.process.ProcessInstance<DataOutputAssociationsHumanTaskModel> instance = processDefinition.createInstance(model);
instance.start();
}
Review Comment:
In all these `testDataOutput*` tests, I am missing some sort of assert statement that actually evaluates the functionality. @Abhitocode I know your task was to migrate the tests as-is, but while we are looking at them, we might at least create another task to improve them in the future. WDYT @elguardian ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "martinweiler (via GitHub)" <gi...@apache.org>.
martinweiler commented on code in PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1700783263
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -325,152 +355,129 @@ public void executeWorkItem(KogitoWorkItem workItem,
@Test
@Disabled
Review Comment:
See comment above regarding disabled tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on code in PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#discussion_r1701976982
##########
jbpm/jbpm-tests/src/test/java/org/jbpm/bpmn2/DataTest.java:
##########
@@ -166,311 +200,281 @@ public void testXpathExpression() throws Exception {
@Test
public void testDataInputAssociations() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociations.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello world");
- }
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello world");
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociations", params);
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
+ org.kie.kogito.process.Process<DataInputAssociationsModel> processDefinition = DataInputAssociationsProcess.newProcess(app);
+ DataInputAssociationsModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithStringObject() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsStringObject.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- @Override
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- @Override
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
-
- });
- Map<String, Object> params = new HashMap<>();
- params.put("instanceMetadata", "hello");
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsStringObject", params);
-
+ public void testDataInputAssociationsWithStringObject() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
+
+ org.kie.kogito.process.Process<DataInputAssociationsStringObjectModel> processDefinition = DataInputAssociationsStringObjectProcess.newProcess(app);
+ DataInputAssociationsStringObjectModel model = processDefinition.createModel();
+ model.setInstanceMetadata("hello");
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringObjectModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
/**
* TODO testDataInputAssociationsWithLazyLoading
*/
@Test
- @Disabled
- public void testDataInputAssociationsWithLazyLoading()
- throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsLazyCreating.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- Element coIdParamObj = (Element) workItem.getParameter("coId");
- assertThat(coIdParamObj.getNodeName()).isEqualTo("mydoc");
- assertThat(coIdParamObj.getFirstChild().getNodeName()).isEqualTo("mynode");
- assertThat(coIdParamObj.getFirstChild().getFirstChild().getNodeName()).isEqualTo("user");
- assertThat(coIdParamObj.getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue()).isEqualTo("hello world");
- }
-
- });
+ public void testDataInputAssociationsWithLazyLoading() throws Exception {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ Element coIdParamObj = (Element) workItem.getParameter("coId");
+ assertThat(coIdParamObj.getNodeName()).isEqualTo("mydoc");
+ assertThat(coIdParamObj.getFirstChild().getNodeName()).isEqualTo("mynode");
+ assertThat(coIdParamObj.getFirstChild().getFirstChild().getNodeName()).isEqualTo("user");
+ assertThat(coIdParamObj.getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue()).isEqualTo("hello world");
+ }
+ });
+
Document document = DocumentBuilderFactory
.newInstance()
.newDocumentBuilder()
- .parse(new ByteArrayInputStream("<user hello='hello world' />"
- .getBytes()));
+ .parse(new ByteArrayInputStream("<user hello='hello world' />".getBytes()));
Map<String, Object> params = new HashMap<>();
params.put("instanceMetadata", document.getFirstChild());
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsLazyCreating", params);
+ org.kie.kogito.process.Process<DataInputAssociationsLazyCreatingModel> processDefinition = DataInputAssociationsLazyCreatingProcess.newProcess(app);
+ DataInputAssociationsLazyCreatingModel model = processDefinition.createModel();
+ model.setInstanceMetadata(document.getFirstChild());
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsLazyCreatingModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithString() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsString.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
+ public void testDataInputAssociationsWithString() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
- });
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsString");
+ org.kie.kogito.process.Process<DataInputAssociationsStringModel> processDefinition = DataInputAssociationsStringProcess.newProcess(app);
+ DataInputAssociationsStringModel model = processDefinition.createModel();
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithStringWithoutQuotes()
- throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsStringNoQuotes.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
+ public void testDataInputAssociationsWithStringWithoutQuotes() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(workItem.getParameter("coId")).isEqualTo("hello");
- }
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(workItem.getParameter("coId")).isEqualTo("hello");
+ }
+ });
- });
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsStringNoQuotes");
+ org.kie.kogito.process.Process<DataInputAssociationsStringNoQuotesModel> processDefinition = DataInputAssociationsStringNoQuotesProcess.newProcess(app);
+ DataInputAssociationsStringNoQuotesModel model = processDefinition.createModel();
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsStringNoQuotesModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
@Test
- public void testDataInputAssociationsWithXMLLiteral() throws Exception {
- kruntime = createKogitoProcessRuntime("org/jbpm/bpmn2/data/BPMN2-DataInputAssociationsXmlLiteral.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getNodeName()).isEqualTo("id");
- assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getFirstChild().getTextContent()).isEqualTo("some text");
- }
-
- });
- KogitoProcessInstance processInstance = kruntime.startProcess("DataInputAssociationsXmlLiteral");
-
+ public void testDataInputAssociationsWithXMLLiteral() {
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getNodeName()).isEqualTo("id");
+ assertThat(((org.w3c.dom.Node) workItem.getParameter("coId")).getFirstChild().getTextContent()).isEqualTo("some text");
+ }
+ });
+
+ org.kie.kogito.process.Process<DataInputAssociationsXmlLiteralModel> processDefinition = DataInputAssociationsXmlLiteralProcess.newProcess(app);
+ DataInputAssociationsXmlLiteralModel model = processDefinition.createModel();
+
+ org.kie.kogito.process.ProcessInstance<DataInputAssociationsXmlLiteralModel> instance = processDefinition.createInstance(model);
+ instance.start();
}
/**
* TODO testDataInputAssociationsWithTwoAssigns
*/
@Test
- @Disabled
public void testDataInputAssociationsWithTwoAssigns() throws Exception {
- kruntime = createKogitoProcessRuntime("BPMN2-DataInputAssociations-two-assigns.bpmn2");
- kruntime.getKogitoWorkItemManager().registerWorkItemHandler("Human Task",
- new KogitoWorkItemHandler() {
-
- public void abortWorkItem(KogitoWorkItem manager,
- KogitoWorkItemManager mgr) {
-
- }
-
- public void executeWorkItem(KogitoWorkItem workItem,
- KogitoWorkItemManager mgr) {
- assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
- // assertEquals("mynode", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getNodeName());
- // assertEquals("user", ((Element)
- // workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
- // assertEquals("hello world", ((Element)
- // workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
- }
-
- });
+ Application app = ProcessTestHelper.newApplication();
+ ProcessTestHelper.registerHandler(app, "Human Task", new KogitoWorkItemHandler() {
+ @Override
+ public void abortWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ }
+
+ @Override
+ public void executeWorkItem(KogitoWorkItem workItem, KogitoWorkItemManager mgr) {
+ assertThat(((Element) workItem.getParameter("Comment")).getNodeName()).isEqualTo("foo");
+ // assertEquals("mynode", ((Element) workItem.getParameter("Comment")).getFirstChild().getNodeName());
+ // assertEquals("user", ((Element) workItem.getParameter("Comment")).getFirstChild().getFirstChild().getNodeName());
+ // assertEquals("hello world", ((Element) workItem.getParameter("coId")).getFirstChild().getFirstChild().getAttributes().getNamedItem("hello").getNodeValue());
Review Comment:
the test passes though uncommented but might be commented as invoking .getNodeName() on null leads to npe.
[INFO] Running org.jbpm.bpmn2.DataTest
org.jbpm.workflow.instance.WorkflowRuntimeException: [DataInputAssociationsTwoAssigns:b065ee88-e816-4dab-
F]] -- Cannot invoke "org.w3c.dom.Element.getNodeName()" because the return value of "org.kie.kogito.internal.process.runtime.KogitoWorkItem.getParameter(String)" is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "elguardian (via GitHub)" <gi...@apache.org>.
elguardian commented on PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#issuecomment-2268281265
@Abhitocode plz fix the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] [incubator-kie-issues-1131] test migration from V7 to code generation-10 [incubator-kie-kogito-runtimes]
Posted by "Abhitocode (via GitHub)" <gi...@apache.org>.
Abhitocode commented on PR #3597:
URL: https://github.com/apache/incubator-kie-kogito-runtimes/pull/3597#issuecomment-2276705631
sure, il update that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org