You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "udayagiri-sivasai-dev (via GitHub)" <gi...@apache.org> on 2026/06/15 23:51:49 UTC

[PR] FINERACT-1788: Split notification queries by read status [fineract]

udayagiri-sivasai-dev opened a new pull request, #5988:
URL: https://github.com/apache/fineract/pull/5988

   ## Description
   
   Splits the notification retrieval query into two explicit repository methods:
   
   * One method retrieves all notifications for the authenticated user.
   * One method retrieves only unread notifications.
   
   This removes the nullable `isRead` parameter and avoids the EclipseLink parameter-binding issue when `null` is passed. The notification read service now calls the appropriate repository method for each use case.
   
   ## Testing
   
   * `.\gradlew.bat :fineract-provider:compileJava`
   * `.\gradlew.bat :fineract-provider:compileTestJava`
   * `.\gradlew.bat spotlessApply`
   * `.\gradlew.bat :integration-tests:test --tests "*NotificationApiTest*" --no-parallel --max-workers=1`
   * `git diff --check`
   * `git diff --cached --check`
   
   All completed successfully.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-1788: Split notification queries by read status [fineract]

Posted by "udayagiri-sivasai-dev (via GitHub)" <gi...@apache.org>.
udayagiri-sivasai-dev commented on PR #5988:
URL: https://github.com/apache/fineract/pull/5988#issuecomment-4764003284

   > @udayagiri-sivasai-dev Please make sure, there is (integration or E2E) test to cover this functionality.
   
   Thanks for the review. I added integration test coverage in `NotificationApiTest.testNotificationReadStatusFiltering()`.
   
   The test verifies that after marking notifications as read, they are removed from the unread result and the regular notification response returns the notification with `isRead = true`.
   
   I also pushed the fix to include `isRead` in the `NotificationData` response mapping.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] FINERACT-1788: Split notification queries by read status [fineract]

Posted by "adamsaghy (via GitHub)" <gi...@apache.org>.
adamsaghy merged PR #5988:
URL: https://github.com/apache/fineract/pull/5988


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org