You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@logging.apache.org by Gary Gregory <ga...@gmail.com> on 2022/03/04 20:09:38 UTC
Fwd: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767: Provide a uniform Log4j 1.x message factory
Hi Piotr and welcome aboard.
I usually update changes.xml but not in a PR, we generate the release notes
from changes.xml.
Gary
---------- Forwarded message ---------
From: GitBox <gi...@apache.org>
Date: Fri, Mar 4, 2022 at 2:57 PM
Subject: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767:
Provide a uniform Log4j 1.x message factory
To: <no...@logging.apache.org>
ppkarwasz merged pull request #767:
URL: https://github.com/apache/logging-log4j2/pull/767
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767: Provide a uniform Log4j 1.x message factory
Posted by Gary Gregory <ga...@gmail.com>.
That's up to you ;-)
Gary
On Fri, Mar 4, 2022, 17:20 Piotr P. Karwasz <pi...@gmail.com> wrote:
> Thanks Gary,
>
> I updated the change list, although I am still not sure which changes
> should be there and which are irrelevant for the users.
>
> Piotr
>
>
> On Fri, Mar 4, 2022 at 9:10 PM Gary Gregory <ga...@gmail.com>
> wrote:
> >
> > Hi Piotr and welcome aboard.
> >
> > I usually update changes.xml but not in a PR, we generate the release
> notes
> > from changes.xml.
> >
> > Gary
> >
> > ---------- Forwarded message ---------
> > From: GitBox <gi...@apache.org>
> > Date: Fri, Mar 4, 2022 at 2:57 PM
> > Subject: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767:
> > Provide a uniform Log4j 1.x message factory
> > To: <no...@logging.apache.org>
> >
> >
> >
> > ppkarwasz merged pull request #767:
> > URL: https://github.com/apache/logging-log4j2/pull/767
> >
> >
> >
> >
> >
> > --
> > This is an automated message from the Apache Git Service.
> > To respond to the message, please log on to GitHub and use the
> > URL above to go to the specific comment.
> >
> > To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
> >
> > For queries about this service, please contact Infrastructure at:
> > users@infra.apache.org
>
Re: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767: Provide a uniform Log4j 1.x message factory
Posted by Ralph Goers <ra...@dslextreme.com>.
In general, if it requires a Jira issue then it should require a changes.xml entry.
Usually, PRs require Jira issues. However, simple doc updates and dependency
updates don’t necessarily require Jira issues although I would prefer to see it
handled differently. But since Gary is the one who seems to spend the most time
updating dependencies he tends to do it in whatever way works for him. Personally,
I would prefer a single Jira issue for each release and have all the dependency
updates be tracked in that.
Ralph
> On Mar 4, 2022, at 3:19 PM, Piotr P. Karwasz <pi...@gmail.com> wrote:
>
> Thanks Gary,
>
> I updated the change list, although I am still not sure which changes
> should be there and which are irrelevant for the users.
>
> Piotr
>
>
> On Fri, Mar 4, 2022 at 9:10 PM Gary Gregory <ga...@gmail.com> wrote:
>>
>> Hi Piotr and welcome aboard.
>>
>> I usually update changes.xml but not in a PR, we generate the release notes
>> from changes.xml.
>>
>> Gary
>>
>> ---------- Forwarded message ---------
>> From: GitBox <gi...@apache.org>
>> Date: Fri, Mar 4, 2022 at 2:57 PM
>> Subject: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767:
>> Provide a uniform Log4j 1.x message factory
>> To: <no...@logging.apache.org>
>>
>>
>>
>> ppkarwasz merged pull request #767:
>> URL: https://github.com/apache/logging-log4j2/pull/767
>>
>>
>>
>>
>>
>> --
>> This is an automated message from the Apache Git Service.
>> To respond to the message, please log on to GitHub and use the
>> URL above to go to the specific comment.
>>
>> To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
>>
>> For queries about this service, please contact Infrastructure at:
>> users@infra.apache.org
Re: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767: Provide a uniform Log4j 1.x message factory
Posted by "Piotr P. Karwasz" <pi...@gmail.com>.
Thanks Gary,
I updated the change list, although I am still not sure which changes
should be there and which are irrelevant for the users.
Piotr
On Fri, Mar 4, 2022 at 9:10 PM Gary Gregory <ga...@gmail.com> wrote:
>
> Hi Piotr and welcome aboard.
>
> I usually update changes.xml but not in a PR, we generate the release notes
> from changes.xml.
>
> Gary
>
> ---------- Forwarded message ---------
> From: GitBox <gi...@apache.org>
> Date: Fri, Mar 4, 2022 at 2:57 PM
> Subject: [GitHub] [logging-log4j2] ppkarwasz merged pull request #767:
> Provide a uniform Log4j 1.x message factory
> To: <no...@logging.apache.org>
>
>
>
> ppkarwasz merged pull request #767:
> URL: https://github.com/apache/logging-log4j2/pull/767
>
>
>
>
>
> --
> This is an automated message from the Apache Git Service.
> To respond to the message, please log on to GitHub and use the
> URL above to go to the specific comment.
>
> To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
>
> For queries about this service, please contact Infrastructure at:
> users@infra.apache.org