[GitHub] [tinkerpop] L0Lmaker commented on a diff in pull request #1671: TINKERPOP-2749: Gremlin Javascript, Gremlint Windows build error fixes

[GitBox <gi...@apache.org>]

L0Lmaker commented on code in PR #1671:
URL: https://github.com/apache/tinkerpop/pull/1671#discussion_r889376669


##########
gremlin-javascript/src/main/javascript/gremlin-javascript/.eslintrc.js:
##########
@@ -31,9 +31,9 @@ module.exports = {
   extends: ['eslint:recommended', 'prettier'],
   plugins: ['prettier'],
   rules: {
-    'prettier/prettier': ['error'],

Review Comment:
   There are two ways we could resolve this. Either allow for `CRLF` formatted files or convert the existing javascript files that use the `CRLF` format to `LF`.  The former felt like a simpler fix which is why I disabled the check for line separators.
   
   If we want to keep it only Unix style, we could go ahead with converting all the JS files that are affected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tinkerpop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org