You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@guacamole.apache.org by "James Muehlner (Jira)" <ji...@apache.org> on 2023/04/13 23:36:00 UTC

[jira] [Created] (GUACAMOLE-1772) Add @NotNull and @Nullable annotations everywhere in guacamole-client Java codebase

James Muehlner created GUACAMOLE-1772:
-----------------------------------------

             Summary: Add @NotNull and @Nullable annotations everywhere in guacamole-client Java codebase
                 Key: GUACAMOLE-1772
                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-1772
             Project: Guacamole
          Issue Type: Improvement
          Components: guacamole-client
            Reporter: James Muehlner


Adding `@Nullable` and `@NotNull` annotations in the Java codebase - this would not only make it easier to understand the code, but it would even have prevented issues like the one described in GUACAMOLE-1769, as the compiler would have caught the potential NPE.

It'd be a big project to add these to the entire codebase at the same time, so maybe it might make sense to break this up into smaller pieces, though adding these annotations often results in a cascading refactor where more and more things need to be annotated.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)