[GitHub] [zookeeper] symat commented on issue #1300: ZOOKEEPER-3769: handling malformed Leader Election notification messages

[GitBox <gi...@apache.org>]

symat commented on issue #1300: ZOOKEEPER-3769: handling malformed Leader Election notification messages
URL: https://github.com/apache/zookeeper/pull/1300#issuecomment-607794733
 
 
   well, actually I was not able to reproduce the issue even with JDK 12. I am not sure if it is specific to JDK 12 or not. I know that the issue was reproducible for Lasaro on his environment (with JDK 12 on CentOS 7) for a while, but now even he can not reproduce it. (Maybe some OS upgrade or network change fixed it for him?) So honestly I don't know what triggered this issue or why we haven't seen this before.
   
   But I think it is good to handle these exceptions in the code, even if I can not trigger them with real ZooKeeper, only by unit tests. And having more tests for malformed / partial messages never hurts. 
   
   Actually one can consider this as a security fix as well, since in theory you were able to knock out any Follower from the quorum just by sending a partial election vote message.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services