You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2021/01/27 18:07:03 UTC
[kudu-CR](branch-1.14.x) KUDU-3239: [build] Disable errorprone on Java 11
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16986
Change subject: KUDU-3239: [build] Disable errorprone on Java 11
......................................................................
KUDU-3239: [build] Disable errorprone on Java 11
It turns out that errorprone is not working with Java 11. This patch
disables it until we can upgrade/update the errorprone plugin to
work on with Java 11.
Change-Id: Ic13f771222e67ac754f464f8015caf0a4901831d
Reviewed-on: http://gerrit.cloudera.org:8080/16983
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 922ab9e7d46f683a5e04b4e36b1af9b95e96e025)
---
M java/gradle/quality.gradle
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/86/16986/1
--
To view, visit http://gerrit.cloudera.org:8080/16986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic13f771222e67ac754f464f8015caf0a4901831d
Gerrit-Change-Number: 16986
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.14.x) KUDU-3239: [build] Disable errorprone on Java 11
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16986 )
Change subject: KUDU-3239: [build] Disable errorprone on Java 11
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/16986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13f771222e67ac754f464f8015caf0a4901831d
Gerrit-Change-Number: 16986
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Jan 2021 18:48:26 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.14.x) KUDU-3239: [build] Disable errorprone on Java 11
Posted by "Bankim Bhavsar (Code Review)" <ge...@cloudera.org>.
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/16986 )
Change subject: KUDU-3239: [build] Disable errorprone on Java 11
......................................................................
Patch Set 1: Code-Review+2
Thanks!
--
To view, visit http://gerrit.cloudera.org:8080/16986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13f771222e67ac754f464f8015caf0a4901831d
Gerrit-Change-Number: 16986
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 27 Jan 2021 18:08:36 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.14.x) KUDU-3239: [build] Disable errorprone on Java 11
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has removed a vote on this change.
Change subject: KUDU-3239: [build] Disable errorprone on Java 11
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/16986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Ic13f771222e67ac754f464f8015caf0a4901831d
Gerrit-Change-Number: 16986
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.14.x) KUDU-3239: [build] Disable errorprone on Java 11
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16986 )
Change subject: KUDU-3239: [build] Disable errorprone on Java 11
......................................................................
KUDU-3239: [build] Disable errorprone on Java 11
It turns out that errorprone is not working with Java 11. This patch
disables it until we can upgrade/update the errorprone plugin to
work on with Java 11.
Change-Id: Ic13f771222e67ac754f464f8015caf0a4901831d
Reviewed-on: http://gerrit.cloudera.org:8080/16983
Reviewed-by: Bankim Bhavsar <ba...@cloudera.com>
Reviewed-by: Hao Hao <ha...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
(cherry picked from commit 922ab9e7d46f683a5e04b4e36b1af9b95e96e025)
Reviewed-on: http://gerrit.cloudera.org:8080/16986
Tested-by: Grant Henke <gr...@apache.org>
---
M java/gradle/quality.gradle
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bankim Bhavsar: Looks good to me, approved
Alexey Serbin: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic13f771222e67ac754f464f8015caf0a4901831d
Gerrit-Change-Number: 16986
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.14.x) KUDU-3239: [build] Disable errorprone on Java 11
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16986 )
Change subject: KUDU-3239: [build] Disable errorprone on Java 11
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/16986
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.14.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13f771222e67ac754f464f8015caf0a4901831d
Gerrit-Change-Number: 16986
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 28 Jan 2021 19:39:56 +0000
Gerrit-HasComments: No