You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Jim Apple (Code Review)" <ge...@cloudera.org> on 2017/11/11 19:34:29 UTC
[Impala-ASF-CR] [DOCS] Remove unnecessary 'incubator' from URLs
Jim Apple has uploaded this change for review. ( http://gerrit.cloudera.org:8080/8524
Change subject: [DOCS] Remove unnecessary 'incubator' from URLs
......................................................................
[DOCS] Remove unnecessary 'incubator' from URLs
URLs like https://impala.incubator.apache.org/ are aliases with
https://impala.apache.org/, so we can use the latter and avoid making
any changes if or when Impala graduates from the incubator.
Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_langref_unsupported.xml
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/8524/1
--
To view, visit http://gerrit.cloudera.org:8080/8524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
Gerrit-Change-Number: 8524
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
[Impala-ASF-CR] [DOCS] Remove unnecessary 'incubator' from URLs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8524 )
Change subject: [DOCS] Remove unnecessary 'incubator' from URLs
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/172/
--
To view, visit http://gerrit.cloudera.org:8080/8524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
Gerrit-Change-Number: 8524
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Nov 2017 18:54:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Remove unnecessary 'incubator' from URLs
Posted by "John Russell (Code Review)" <ge...@cloudera.org>.
John Russell has posted comments on this change. ( http://gerrit.cloudera.org:8080/8524 )
Change subject: [DOCS] Remove unnecessary 'incubator' from URLs
......................................................................
Patch Set 1:
(1 comment)
Excellent idea!
http://gerrit.cloudera.org:8080/#/c/8524/1/docs/topics/impala_langref_unsupported.xml
File docs/topics/impala_langref_unsupported.xml:
http://gerrit.cloudera.org:8080/#/c/8524/1/docs/topics/impala_langref_unsupported.xml@207
PS1, Line 207: <xref href="http://sentry.apache.org/" scope="external" format="html">
Might as well shorten this opening tag to <xref keyref="sentry">. That way it picks up the Sentry-related modification from impala_keydefs.ditamap, the line is shorter, and link maintenance is easier in future (link can be changed again - to https:// or whatever - without touching any topics/*.xml files).
--
To view, visit http://gerrit.cloudera.org:8080/8524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
Gerrit-Change-Number: 8524
Gerrit-PatchSet: 1
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 11 Nov 2017 21:05:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Remove unnecessary 'incubator' from URLs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/8524 )
Change subject: [DOCS] Remove unnecessary 'incubator' from URLs
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/8524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
Gerrit-Change-Number: 8524
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Nov 2017 18:59:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Remove unnecessary 'incubator' from URLs
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change. ( http://gerrit.cloudera.org:8080/8524 )
Change subject: [DOCS] Remove unnecessary 'incubator' from URLs
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/8524/1/docs/topics/impala_langref_unsupported.xml
File docs/topics/impala_langref_unsupported.xml:
http://gerrit.cloudera.org:8080/#/c/8524/1/docs/topics/impala_langref_unsupported.xml@207
PS1, Line 207: <xref keyref="sentry">Apache
> Might as well shorten this opening tag to <xref keyref="sentry">. That way
Done
--
To view, visit http://gerrit.cloudera.org:8080/8524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
Gerrit-Change-Number: 8524
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Sat, 11 Nov 2017 21:45:25 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] [DOCS] Remove unnecessary 'incubator' from URLs
Posted by "Michael Brown (Code Review)" <ge...@cloudera.org>.
Michael Brown has posted comments on this change. ( http://gerrit.cloudera.org:8080/8524 )
Change subject: [DOCS] Remove unnecessary 'incubator' from URLs
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/8524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
Gerrit-Change-Number: 8524
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Nov 2017 18:39:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] [DOCS] Remove unnecessary 'incubator' from URLs
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/8524 )
Change subject: [DOCS] Remove unnecessary 'incubator' from URLs
......................................................................
[DOCS] Remove unnecessary 'incubator' from URLs
URLs like https://impala.incubator.apache.org/ are aliases with
https://impala.apache.org/, so we can use the latter and avoid making
any changes if or when Impala graduates from the incubator.
Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
Reviewed-on: http://gerrit.cloudera.org:8080/8524
Reviewed-by: Michael Brown <mi...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_langref_unsupported.xml
2 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Michael Brown: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/8524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
Gerrit-Change-Number: 8524
Gerrit-PatchSet: 3
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>
[Impala-ASF-CR] [DOCS] Remove unnecessary 'incubator' from URLs
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Hello Michael Brown, John Russell, Laurel Hale,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/8524
to look at the new patch set (#2).
Change subject: [DOCS] Remove unnecessary 'incubator' from URLs
......................................................................
[DOCS] Remove unnecessary 'incubator' from URLs
URLs like https://impala.incubator.apache.org/ are aliases with
https://impala.apache.org/, so we can use the latter and avoid making
any changes if or when Impala graduates from the incubator.
Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
---
M docs/impala_keydefs.ditamap
M docs/topics/impala_langref_unsupported.xml
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/24/8524/2
--
To view, visit http://gerrit.cloudera.org:8080/8524
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If0f8d51b147094e629e60c4a8c5aecbb6cdb6a8e
Gerrit-Change-Number: 8524
Gerrit-PatchSet: 2
Gerrit-Owner: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: John Russell <jr...@cloudera.com>
Gerrit-Reviewer: Laurel Hale <la...@cloudera.com>
Gerrit-Reviewer: Michael Brown <mi...@cloudera.com>