You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/09/09 09:07:05 UTC
[GitHub] [doris] jackwener opened a new pull request, #12511: [feature](Nereids): Eliminate redundant filter and limit.
jackwener opened a new pull request, #12511:
URL: https://github.com/apache/doris/pull/12511
# Proposed changes
Issue Number: close #xxx
## Problem summary
- Eliminate redundant filter and limit.
- Make BooleanLiteral use INSTANCE
## Checklist(Required)
1. Does it affect the original behavior:
- [x] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [x] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [x] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener commented on a diff in pull request #12511: [feature](Nereids): Eliminate redundant filter and limit.
Posted by GitBox <gi...@apache.org>.
jackwener commented on code in PR #12511:
URL: https://github.com/apache/doris/pull/12511#discussion_r969165351
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/BooleanLiteral.java:
##########
@@ -32,11 +32,27 @@ public class BooleanLiteral extends Literal {
private final boolean value;
- public BooleanLiteral(boolean value) {
+ private BooleanLiteral(boolean value) {
super(BooleanType.INSTANCE);
this.value = value;
}
+ public static BooleanLiteral of(boolean value) {
+ if (value) {
+ return TRUE;
+ } else {
+ return FALSE;
+ }
+ }
+
+ public static BooleanLiteral of(Boolean value) {
Review Comment:
Literal also has `of` function, if this don't exist, `Literal of` will call itself which is dead loop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener merged pull request #12511: [feature](Nereids): Eliminate redundant filter and limit.
Posted by GitBox <gi...@apache.org>.
jackwener merged PR #12511:
URL: https://github.com/apache/doris/pull/12511
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12511: [feature](Nereids): Eliminate redundant filter and limit.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12511:
URL: https://github.com/apache/doris/pull/12511#issuecomment-1245319556
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #12511: [feature](Nereids): Eliminate redundant filter and limit.
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #12511:
URL: https://github.com/apache/doris/pull/12511#discussion_r969132655
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/literal/BooleanLiteral.java:
##########
@@ -32,11 +32,27 @@ public class BooleanLiteral extends Literal {
private final boolean value;
- public BooleanLiteral(boolean value) {
+ private BooleanLiteral(boolean value) {
super(BooleanType.INSTANCE);
this.value = value;
}
+ public static BooleanLiteral of(boolean value) {
+ if (value) {
+ return TRUE;
+ } else {
+ return FALSE;
+ }
+ }
+
+ public static BooleanLiteral of(Boolean value) {
Review Comment:
i think we do not need this function, since java could do auto unboxing
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/logical/EliminateFilter.java:
##########
@@ -0,0 +1,39 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.doris.nereids.rules.rewrite.logical;
+
+import org.apache.doris.nereids.rules.Rule;
+import org.apache.doris.nereids.rules.RuleType;
+import org.apache.doris.nereids.rules.rewrite.OneRewriteRuleFactory;
+import org.apache.doris.nereids.trees.expressions.literal.BooleanLiteral;
+import org.apache.doris.nereids.trees.plans.logical.LogicalEmptyRelation;
+
+import java.util.List;
+
+/**
+ * Eliminate filter false.
+ */
+public class EliminateFilter extends OneRewriteRuleFactory {
+ @Override
+ public Rule build() {
+ return logicalFilter()
+ .when(filter -> filter.getPredicates() == BooleanLiteral.FALSE)
+ .then(limit -> new LogicalEmptyRelation((List) limit.getOutput()))
Review Comment:
```suggestion
.then(filter -> new LogicalEmptyRelation((List) filter.getOutput()))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #12511: [feature](Nereids): Eliminate redundant filter and limit.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #12511:
URL: https://github.com/apache/doris/pull/12511#issuecomment-1245319503
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org