[GitHub] [hadoop] steveloughran commented on a diff in pull request #4925: HADOOP-18465. Fix S3A SSE test skip when encryption is disabled

[GitBox <gi...@apache.org>]

steveloughran commented on code in PR #4925:
URL: https://github.com/apache/hadoop/pull/4925#discussion_r988925268


##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractTestS3AEncryption.java:
##########
@@ -78,6 +78,14 @@ protected void patchConfigurationEncryptionSettings(
       0, 1, 2, 3, 4, 5, 254, 255, 256, 257, 2 ^ 12 - 1
   };
 
+  /**
+   * Skips the tests if encryption is not enabled in configuration.
+   *
+   * @implNote We can use {@link #createConfiguration()} here since

Review Comment:
   not sure if maven is set up to use those tags; no reason why we shouldn't start though



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org