You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "xujianhai666 (GitHub)" <gi...@apache.org> on 2019/11/25 01:42:28 UTC

[GitHub] [dubbo-go] xujianhai666 opened pull request #263: feat(jsonrpc): refactor code


[ Full content available at: https://github.com/apache/dubbo-go/pull/263 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] codecov-io commented on issue #263: feat(jsonrpc): refactor code

Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/263?src=pr&el=h1) Report
> Merging [#263](https://codecov.io/gh/apache/dubbo-go/pull/263?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/a6dd43f50c665b85ee59aa3194e7e389e54851eb?src=pr&el=desc) will **increase** coverage by `0.05%`.
> The diff coverage is `100%`.

[![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/263/graphs/tree.svg?width=650&token=dcPE6RyFAL&height=150&src=pr)](https://codecov.io/gh/apache/dubbo-go/pull/263?src=pr&el=tree)

```diff
@@             Coverage Diff             @@
##           develop     #263      +/-   ##
===========================================
+ Coverage    65.51%   65.57%   +0.05%     
===========================================
  Files          111      111              
  Lines         7038     7038              
===========================================
+ Hits          4611     4615       +4     
+ Misses        1971     1967       -4     
  Partials       456      456
```


| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/263?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [protocol/jsonrpc/http.go](https://codecov.io/gh/apache/dubbo-go/pull/263/diff?src=pr&el=tree#diff-cHJvdG9jb2wvanNvbnJwYy9odHRwLmdv) | `76.31% <100%> (ø)` | :arrow_up: |
| [registry/etcdv3/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/263/diff?src=pr&el=tree#diff-cmVnaXN0cnkvZXRjZHYzL3JlZ2lzdHJ5Lmdv) | `51.51% <0%> (+1.01%)` | :arrow_up: |
| [config\_center/apollo/impl.go](https://codecov.io/gh/apache/dubbo-go/pull/263/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9hcG9sbG8vaW1wbC5nbw==) | `87.01% <0%> (+2.59%)` | :arrow_up: |

------

[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/263?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/263?src=pr&el=footer). Last update [a6dd43f...4c1fb37](https://codecov.io/gh/apache/dubbo-go/pull/263?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).


[ Full content available at: https://github.com/apache/dubbo-go/pull/263 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks closed pull request #263: feat(jsonrpc): refactor code

Posted by "AlexStocks (GitHub)" <gi...@apache.org>.
[ pull request closed by AlexStocks ]

[ Full content available at: https://github.com/apache/dubbo-go/pull/263 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org