Re: [PR] [FLINK-40488][table] Support UUID as a comparison, ordering, and aggregation key [flink]

["raminqaf (via GitHub)" <gi...@apache.org>]

raminqaf commented on code in PR #29128:
URL: https://github.com/apache/flink/pull/29128#discussion_r3958998991


##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/AggregateUtil.scala:
##########
@@ -919,6 +919,11 @@ object AggregateUtil extends Enumeration {
             TIMESTAMP_WITH_LOCAL_TIME_ZONE | INTERVAL_YEAR_MONTH | INTERVAL_DAY_TIME | ARRAY |
             VARIANT | BITMAP =>
           argTypes(0)
+        case UUID =>

Review Comment:
   Later we can add support for BINARY/VARBINARY/BYTES too



##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/plan/utils/AggregateUtil.scala:
##########
@@ -919,6 +919,11 @@ object AggregateUtil extends Enumeration {
             TIMESTAMP_WITH_LOCAL_TIME_ZONE | INTERVAL_YEAR_MONTH | INTERVAL_DAY_TIME | ARRAY |
             VARIANT | BITMAP =>
           argTypes(0)
+        case UUID =>

Review Comment:
   If this approach is acceptable, later we can add support for BINARY/VARBINARY/BYTES too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org