You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fluss.apache.org by "beryllw (via GitHub)" <gi...@apache.org> on 2026/08/28 15:49:17 UTC

[PR] [gateway] Include concrete path in REST access logs [fluss]

beryllw opened a new pull request, #4142:
URL: https://github.com/apache/fluss/pull/4142

   ### Purpose
   
   Add the concrete request path to Gateway REST completion logs while keeping the matched route template for low-cardinality metrics.
   
   Linked issue: N/A (small observability fix)
   
   ### Brief change log
   
   - Capture `Request::uri().path()` before dispatching the request.
   - Add `path=...` to completion logs without changing metric labels.
   - Verify that route and path are logged separately.
   
   ### Tests
   
   - `cargo fmt --all -- --check`
   - `cargo test --all-targets`
   - `cargo clippy --all-targets -- -D warnings`
   
   ### API and Format
   
   No public API or storage-format changes. REST completion log lines gain a `path` field.
   
   ### Documentation
   
   No documentation changes are needed.
   
   ### Generative AI disclosure
   
   - [x] Yes — OpenAI Codex
   
   <!-- Generated-by: OpenAI Codex following https://github.com/apache/fluss/blob/main/AGENTS.md -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [gateway] Include concrete path in REST access logs [fluss]

Posted by "beryllw (via GitHub)" <gi...@apache.org>.
beryllw commented on PR #4142:
URL: https://github.com/apache/fluss/pull/4142#issuecomment-5454693992

   Docker log comparison after sending a write request through the Gateway container:
   
   Before:
   
   ```text
   INFO fluss_gateway::protocol::rest method=POST route=/v1/clusters/{cluster}/databases/{database}/tables/{table}/records request_id=3ccd4ddc-28db-42fc-b8b6-acc1b54e850b status=200 elapsed_ms=20
   ```
   
   After:
   
   ```text
   INFO fluss_gateway::protocol::rest method=POST route=/v1/clusters/{cluster}/databases/{database}/tables/{table}/records path=/v1/clusters/local/databases/my_db/tables/my_table/records request_id=3ccd4ddc-28db-42fc-b8b6-acc1b54e850b status=200 elapsed_ms=20
   ```
   
   The bounded `route` remains available for aggregation, while `path` identifies the concrete database and table. Query parameters remain excluded.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [gateway] Include concrete path in REST access logs [fluss]

Posted by "fresh-borzoni (via GitHub)" <gi...@apache.org>.
fresh-borzoni merged PR #4142:
URL: https://github.com/apache/fluss/pull/4142


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [gateway] Include concrete path in REST access logs [fluss]

Posted by "beryllw (via GitHub)" <gi...@apache.org>.
beryllw commented on PR #4142:
URL: https://github.com/apache/fluss/pull/4142#issuecomment-5454706543

   @fresh-borzoni @naivedogger cc


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fluss.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org