[GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #4865: Misc clean up for PinotHelixResourceManager

[GitBox <gi...@apache.org>]

mcvsubbu commented on a change in pull request #4865: Misc clean up for PinotHelixResourceManager
URL: https://github.com/apache/incubator-pinot/pull/4865#discussion_r351419620
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java
 ##########
 @@ -1321,19 +1304,15 @@ public void updateIndexingConfigFor(String tableName, TableType type, IndexingCo
     setExistingTableConfig(tableConfig);
   }
 
-  private void handleBrokerResource(@Nonnull final String tableName, @Nonnull final List<String> brokersForTenant) {
-    LOGGER.info("Updating BrokerResource IdealState for table: {}", tableName);
-    HelixHelper
-        .updateIdealState(_helixZkManager, Helix.BROKER_RESOURCE_INSTANCE, new Function<IdealState, IdealState>() {
-          @Override
-          public IdealState apply(@Nullable IdealState idealState) {
-            Preconditions.checkNotNull(idealState);
-            for (String broker : brokersForTenant) {
-              idealState.setPartitionState(tableName, broker, BrokerOnlineOfflineStateModel.ONLINE);
-            }
-            return idealState;
-          }
-        }, RetryPolicies.exponentialBackoffRetryPolicy(5, 500L, 2.0f));
+  private void handleBrokerResource(String tableNameWithType, List<String> brokersForTenant) {
 
 Review comment:
   suggest rename to enableTableInBrokers(). Or, updateBrokerResource() but that is more vague.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org