[jira] [Created] (MESOS-4535) Logrotate ContainerLogger may not handle FD ownership correctly

["Joseph Wu (JIRA)" <ji...@apache.org>]

Joseph Wu created MESOS-4535:
--------------------------------

             Summary: Logrotate ContainerLogger may not handle FD ownership correctly
                 Key: MESOS-4535
                 URL: https://issues.apache.org/jira/browse/MESOS-4535
             Project: Mesos
          Issue Type: Bug
          Components: modules
            Reporter: Joseph Wu
            Assignee: Joseph Wu
            Priority: Blocker


One of the patches for [MESOS-4136] introduced the {{FDType::OWNED}} enum for {{Subprocess::IO::FD}}.

The way the logrotate module uses this is slightly incorrect:
# The module starts a subprocess with an output {{Subprocess::PIPE()}}.
# That pipe's FD is passed into another subprocess via {{Subprocess::IO::FD(pipe, IO::OWNED)}}.
# When the second subprocess starts, the pipe's FD is closed in the parent.
# When the first subprocess terminates, the existing code will try to close the pipe again.  This effectively closes a random FD.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)