[GitHub] [airflow] 11010cy edited a comment on issue #22638: 'dict' object has no attribute 'dump'

[GitBox <gi...@apache.org>]

11010cy edited a comment on issue #22638:
URL: https://github.com/apache/airflow/issues/22638#issuecomment-1084216788


   I found that it caused by requesting `/dags/{}/dagRuns/{dag_run_id}/taskInstances/{task_instance_id}/logs/1`. 
   ```
   // utils/log/file_task_handler.py _render_filename
   context = ti.get_template_context()
   ```
   but get_template_context has the side effect that it changed task.params to dict. (params.validate() return a dict)
   ```
   //  models/taskintance.py get_template_context
   validated_params = task.params = params.validate()
   ```
   The related commits are:
   https://github.com/apache/airflow/commit/2258e13cc78faec80054c223eca9378fd33e18fd
   https://github.com/apache/airflow/commit/23a68fa4e61ba795340f095ab64fbcaeebd57db4
   
   The problem was introduced by https://github.com/apache/airflow/commit/23a68fa4e61ba795340f095ab64fbcaeebd57db4, fixed at https://github.com/apache/airflow/commit/2258e13cc78faec80054c223eca9378fd33e18fd(not released). And exists in  apache-airflow >= 2.1.4.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org