You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by andrewor14 <gi...@git.apache.org> on 2014/08/07 20:51:18 UTC

[GitHub] spark pull request: [HOTFIX][STREAMING] Allow the JVM/Netty to dec...

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1820#discussion_r15955736
  
    --- Diff: external/flume-sink/src/main/scala/org/apache/spark/streaming/flume/sink/SparkSink.scala ---
    @@ -131,6 +131,13 @@ class SparkSink extends AbstractSink with Logging with Configurable {
         blockingLatch.await()
         Status.BACKOFF
       }
    +
    +  private[flume] def getPort(): Int = {
    +    val server = serverOpt.getOrElse(
    +      throw new RuntimeException("Server was not started!")
    +    )
    +    server.getPort
    --- End diff --
    
    How about `serverOpt.map(_.getPort).getOrElse(throw new RuntimeException(...)`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org