You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/07/17 11:22:12 UTC

[GitHub] [skywalking] suresh-pandi opened a new issue #5119: Inquiry: can we monitor db connection pool

suresh-pandi opened a new issue #5119:
URL: https://github.com/apache/skywalking/issues/5119


   Please answer these questions before submitting your issue.
   
   - Why do you submit this issue?
   - [*] Question or discussion
   - [ ] Bug
   - [ ] Requirement
   - [ ] Feature or performance improvement
   
   ___
   ### Question
   - What do you want to know?
   can we monitor db connection pool ? i am using java application hosted on tomcat connecting to mysql. would like few metrics like total number of connections used, time taken to obtain connection from connection pool.
   ___
   ### Bug
   - Which version of SkyWalking, OS and JRE?
   
   - Which company or project?
   
   - What happen?
   If possible, provide a way for reproducing the error. e.g. demo application, component version.
   
   ___
   ### Requirement or improvement
   - Please describe about your requirements or improvement suggestions.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956295624


   Isn't API doc clear enough? What is the demo?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-922757239


   DBCP, Alibaba Druid(https://github.com/apache/skywalking-java/pull/27), and HikariCP(https://github.com/apache/skywalking-java/pull/29) are supported now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956205676


   > > DBCP, Alibaba Druid([apache/skywalking-java#27](https://github.com/apache/skywalking-java/pull/27)), and HikariCP([apache/skywalking-java#29](https://github.com/apache/skywalking-java/pull/29)) are supported now.
   > > Add this Druid plugins only have trace data.  Does this plugin have metrics like jdbc_connections_max?
   
   They didn't provide meter reporting. We provided APIs for plugins.
   https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/java-plugin-development-guide/#meter-plugin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wuguanyu commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wuguanyu commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956292693


   > > > > > DBCP, Alibaba Druid([apache/skywalking-java#27](https://github.com/apache/skywalking-java/pull/27)), and HikariCP([apache/skywalking-java#29](https://github.com/apache/skywalking-java/pull/29)) are supported now.
   > > > > > Add this Druid plugins only have trace data.  Does this plugin have metrics like jdbc_connections_max?
   > > > 
   > > > 
   > > > They didn't provide meter reporting. We provided APIs for plugins. https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/java-plugin-development-guide/#meter-plugin
   > > 
   > > 
   > > import skywalking-sdk dependency, and use skywalking api to report metric when we use java-agent right ?
   > 
   > > > import skywalking-sdk dependency
   > 
   > No, this isn't this API for. These APIs are designed for plugins, which allow no-code changes from end users.
   
   Does it has any demo in java plugins?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956212968


   > > > > DBCP, Alibaba Druid([apache/skywalking-java#27](https://github.com/apache/skywalking-java/pull/27)), and HikariCP([apache/skywalking-java#29](https://github.com/apache/skywalking-java/pull/29)) are supported now.
   > > > > Add this Druid plugins only have trace data.  Does this plugin have metrics like jdbc_connections_max?
   > > 
   > > 
   > > They didn't provide meter reporting. We provided APIs for plugins. https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/java-plugin-development-guide/#meter-plugin
   > 
   > import skywalking-sdk dependency, and use skywalking api to report metric when we use java-agent right ?
   
   > > import skywalking-sdk dependency
   
   No, this isn't this API for.
   These APIs are designed for plugins, which allow no-code changes from end users. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wuguanyu edited a comment on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wuguanyu edited a comment on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956318483


    <dependency>
         <groupId>org.apache.skywalking</groupId>
         <artifactId>apm-toolkit-meter</artifactId>
         <version>${skywalking.version}</version>
      </dependency>
      I can understand this api, use meter api in target app.
   but in agent plugin, i don't how to use meter api  in java agent plugin 
   This meter api in skywalking java agent was just used in unitTest


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wuguanyu commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wuguanyu commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956292359


   > > > > > DBCP, Alibaba Druid([apache/skywalking-java#27](https://github.com/apache/skywalking-java/pull/27)), and HikariCP([apache/skywalking-java#29](https://github.com/apache/skywalking-java/pull/29)) are supported now.
   > > > > > Add this Druid plugins only have trace data.  Does this plugin have metrics like jdbc_connections_max?
   > > > 
   > > > 
   > > > They didn't provide meter reporting. We provided APIs for plugins. https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/java-plugin-development-guide/#meter-plugin
   > > 
   > > 
   > > import skywalking-sdk dependency, and use skywalking api to report metric when we use java-agent right ?
   > 
   > > > import skywalking-sdk dependency
   > 
   > No, this isn't this API for. These APIs are designed for plugins, which allow no-code changes from end users.
   
   Does it has any demo in java plugins?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wuguanyu removed a comment on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wuguanyu removed a comment on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956292693


   > > > > > DBCP, Alibaba Druid([apache/skywalking-java#27](https://github.com/apache/skywalking-java/pull/27)), and HikariCP([apache/skywalking-java#29](https://github.com/apache/skywalking-java/pull/29)) are supported now.
   > > > > > Add this Druid plugins only have trace data.  Does this plugin have metrics like jdbc_connections_max?
   > > > 
   > > > 
   > > > They didn't provide meter reporting. We provided APIs for plugins. https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/java-plugin-development-guide/#meter-plugin
   > > 
   > > 
   > > import skywalking-sdk dependency, and use skywalking api to report metric when we use java-agent right ?
   > 
   > > > import skywalking-sdk dependency
   > 
   > No, this isn't this API for. These APIs are designed for plugins, which allow no-code changes from end users.
   
   Does it has any demo in java plugins?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng closed issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wu-sheng closed issue #5119:
URL: https://github.com/apache/skywalking/issues/5119


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956322806


   I just provided the link for the doc. The plugin APIs have nothing related to toolkit. 
   
   `What is plugin API?`, the APIs you used in plugin(interceptors) to create spans(tags, context, etc.) are the tracing APIs. In the same time, we provided the meter API for metrics collecting.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wuguanyu commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wuguanyu commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956330767


   > I just provided the link for the doc. The plugin APIs have nothing related to toolkit.
   > 
   > `What is plugin API?`, the APIs you used in plugin(interceptors) to create spans(tags, context, etc.) are the tracing APIs. In the same time, we provided the meter API for metrics collecting.
   
   I understood, Thanks I need modify plugin (interceptors) what i need


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-660111073


   I think @ascrutae is working on this part, but it will take time. This is not a small feature.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wuguanyu commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wuguanyu commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956209013


   > > > DBCP, Alibaba Druid([apache/skywalking-java#27](https://github.com/apache/skywalking-java/pull/27)), and HikariCP([apache/skywalking-java#29](https://github.com/apache/skywalking-java/pull/29)) are supported now.
   > > > Add this Druid plugins only have trace data.  Does this plugin have metrics like jdbc_connections_max?
   > 
   > They didn't provide meter reporting. We provided APIs for plugins. https://skywalking.apache.org/docs/skywalking-java/latest/en/setup/service-agent/java-agent/java-plugin-development-guide/#meter-plugin
   
   import skywalking-sdk dependency, and use skywalking api to report metric when we use java-agent right ?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wuguanyu commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wuguanyu commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956204233


   > DBCP, Alibaba Druid([apache/skywalking-java#27](https://github.com/apache/skywalking-java/pull/27)), and HikariCP([apache/skywalking-java#29](https://github.com/apache/skywalking-java/pull/29)) are supported now.
   Add this Druid plugins only have trace data.  Does this plugin have metrics like jdbc_connections_max? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wuguanyu commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wuguanyu commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956330767


   > I just provided the link for the doc. The plugin APIs have nothing related to toolkit.
   > 
   > `What is plugin API?`, the APIs you used in plugin(interceptors) to create spans(tags, context, etc.) are the tracing APIs. In the same time, we provided the meter API for metrics collecting.
   
   I understood, Thanks I need modify plugin (interceptors) what i need


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956333716


   Yes, also you need to setup meter analysis rule(MAL engine) to parse the meter data to queryable data. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wu-sheng commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wu-sheng commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956333716


   Yes, also you need to setup meter analysis rule(MAL engine) to parse the meter data to queryable data. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [skywalking] wuguanyu commented on issue #5119: Inquiry: can we monitor db connection pool

Posted by GitBox <gi...@apache.org>.
wuguanyu commented on issue #5119:
URL: https://github.com/apache/skywalking/issues/5119#issuecomment-956318483


    <dependency>
         <groupId>org.apache.skywalking</groupId>
         <artifactId>apm-toolkit-meter</artifactId>
         <version>${skywalking.version}</version>
      </dependency>
      I can understand this api, use meter api in target app.
   but in agent plugin, i don't how to use meter api  in java agent plugin 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org