You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/01/24 22:25:02 UTC

[GitHub] [incubator-superset] willbarrett commented on a change in pull request #9018: Add revert guidelines to CONTRIBUTING.md

willbarrett commented on a change in pull request #9018: Add revert guidelines to CONTRIBUTING.md
URL: https://github.com/apache/incubator-superset/pull/9018#discussion_r370869393
 
 

 ##########
 File path: CONTRIBUTING.md
 ##########
 @@ -226,6 +227,21 @@ If the PR passes CI tests and does not have any `need:` labels, it is ready for
 
 If an issue/PR has been inactive for >=30 days, it will be closed. If it does not have any status label, add `inactive`.
 
+## Revert Guidelines
+
+Reverting changes that are causing issues in the master branch is a normal and expected part of the development process. In an open source community, the ramifications of a change cannot always be fully understood. With that in mind, here are some considerations to keep in mind when considering a revert:
 
 Review comment:
   Good point. Will add.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org