You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/12/03 12:57:06 UTC
[GitHub] [dubbo-go] wenxuwan opened a new pull request #907: FIX:#906
wenxuwan opened a new pull request #907:
URL: https://github.com/apache/dubbo-go/pull/907
As title, try to fix panic when zk disconnected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #907: FIX:#906
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #907:
URL: https://github.com/apache/dubbo-go/pull/907
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] wenxuwan commented on pull request #907: FIX:#906
Posted by GitBox <gi...@apache.org>.
wenxuwan commented on pull request #907:
URL: https://github.com/apache/dubbo-go/pull/907#issuecomment-738601055
> Which version would you want to fix ? in 1.4.5 or the lastest version？ You use 1.4.5
>
> #906
common issue, we can merge into develop branch, i use my own branch local which fork from 1.4.5.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #907: FIX:#906
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #907:
URL: https://github.com/apache/dubbo-go/pull/907#issuecomment-737970422
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/907?src=pr&el=h1) Report
> Merging [#907](https://codecov.io/gh/apache/dubbo-go/pull/907?src=pr&el=desc) (ee35594) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/2b8aad0ab1a59c1801483b375960f3f02170e6d8?el=desc) (2b8aad0) will **decrease** coverage by `0.32%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/dubbo-go/pull/907?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #907 +/- ##
===========================================
- Coverage 60.11% 59.78% -0.33%
===========================================
Files 260 260
Lines 12781 12854 +73
===========================================
+ Hits 7683 7685 +2
- Misses 4137 4206 +69
- Partials 961 963 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/907?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [registry/zookeeper/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/907/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL3JlZ2lzdHJ5Lmdv) | `50.36% <0.00%> (-1.52%)` | :arrow_down: |
| [remoting/getty/readwriter.go](https://codecov.io/gh/apache/dubbo-go/pull/907/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcmVhZHdyaXRlci5nbw==) | `42.85% <0.00%> (-11.43%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/907/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-10.17%)` | :arrow_down: |
| [...tocol/rest/server/server\_impl/go\_restful\_server.go](https://codecov.io/gh/apache/dubbo-go/pull/907/diff?src=pr&el=tree#diff-cHJvdG9jb2wvcmVzdC9zZXJ2ZXIvc2VydmVyX2ltcGwvZ29fcmVzdGZ1bF9zZXJ2ZXIuZ28=) | `43.90% <0.00%> (-4.88%)` | :arrow_down: |
| [remoting/getty/getty\_client.go](https://codecov.io/gh/apache/dubbo-go/pull/907/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvZ2V0dHlfY2xpZW50Lmdv) | `41.97% <0.00%> (-4.62%)` | :arrow_down: |
| [remoting/getty/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/907/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvbGlzdGVuZXIuZ28=) | `41.08% <0.00%> (-1.18%)` | :arrow_down: |
| [remoting/getty/pool.go](https://codecov.io/gh/apache/dubbo-go/pull/907/diff?src=pr&el=tree#diff-cmVtb3RpbmcvZ2V0dHkvcG9vbC5nbw==) | `68.72% <0.00%> (-0.89%)` | :arrow_down: |
| [protocol/dubbo/impl/hessian.go](https://codecov.io/gh/apache/dubbo-go/pull/907/diff?src=pr&el=tree#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9oZXNzaWFuLmdv) | `29.17% <0.00%> (-0.27%)` | :arrow_down: |
| [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/907/diff?src=pr&el=tree#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `67.16% <0.00%> (+0.49%)` | :arrow_up: |
| ... and [1 more](https://codecov.io/gh/apache/dubbo-go/pull/907/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/907?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/907?src=pr&el=footer). Last update [2b8aad0...ee35594](https://codecov.io/gh/apache/dubbo-go/pull/907?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org