You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by Thorsten Scherler <th...@juntadeandalucia.es> on 2008/07/01 09:04:58 UTC
Re: Concurrency testing of the locationmap throws errors
On Mon, 2008-06-30 at 09:14 -0400, Tim Williams wrote:
> On Mon, Jun 30, 2008 at 9:04 AM, Thorsten Scherler
> <th...@juntadeandalucia.es> wrote:svnc
> > On Mon, 2008-06-30 at 08:34 -0400, Tim Williams wrote:
> >> On Mon, Jun 30, 2008 at 8:12 AM, Thorsten Scherler
> > ...
> >>
> >> I reckon in that case, it's either the caching or its deeper in the
> >> actual LM/nodes. You could try turning off caching completely and see
> >> if it helps.
> >
> > Turning caching off does not change the situation.
> >
> >> Or, you could change the implementation from a HashMap
> >> to a ConcurrentHashMap and see if that helps.
> >
> > I changed
> > public synchronized Object getAttribute(...)
> > which seems to fix the problem.
> >
> > :)
>
> I'm not sure that having getAttribute synchronized is good long term.
> Have you noticed a performance problems now? Maybe create an issue to
> review this and figure out what the real culprit is in there?
>
I will test the performance but in any case I think this problem needs
to fixed since concurrency bugs are really ugly to debug and having this
problem in a high traffic site is a complete showstopper.
I agree that there may is a better solution then having getAttribute
synchronized, I will ask on cocoon-dev.
I created FOR-1082 and added a note to the code.
salu2
--
Thorsten Scherler thorsten.at.apache.org
Open Source Java consulting, training and solutions
Re: Concurrency testing of the locationmap throws errors
Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Tue, 2008-07-01 at 09:25 +0200, Thorsten Scherler wrote:
> On Tue, 2008-07-01 at 09:04 +0200, Thorsten Scherler wrote:
> ...
> > I will test the performance
> ...
>
> Actually with the same test as before the performance is better.
>
> Mainly because before the first results are errors and ruin the average.
> Since now we have 0% error the first hits are around 2.5/sec and raise
> to 5.1/sec.
BTW the site I am testing is http://juntadeandalucia.es/
(dispatcher/cocoon-2.2 based) and now with 250 threads in parallel
doing each 100 request to different pages of the app brings me with lm
caching enabled a throughput of 52,5 /sec (sample size 8855 requests).
salu2
--
Thorsten Scherler thorsten.at.apache.org
Open Source Java consulting, training and solutions
Re: Concurrency testing of the locationmap throws errors
Posted by Thorsten Scherler <th...@juntadeandalucia.es>.
On Tue, 2008-07-01 at 09:04 +0200, Thorsten Scherler wrote:
...
> I will test the performance
...
Actually with the same test as before the performance is better.
Mainly because before the first results are errors and ruin the average.
Since now we have 0% error the first hits are around 2.5/sec and raise
to 5.1/sec.
salu2
--
Thorsten Scherler thorsten.at.apache.org
Open Source Java consulting, training and solutions