You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/23 19:22:47 UTC

[GitHub] [arrow] kiszk commented on pull request #8721: ARROW-10662: [Java] Avoid integer overflow for Json file reader

kiszk commented on pull request #8721:
URL: https://github.com/apache/arrow/pull/8721#issuecomment-732373171


   LGTM.
   
   One comment. I found a similar problem at [here](https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/DecimalVector.java#L150) while [this code](https://github.com/apache/arrow/blob/master/java/vector/src/main/java/org/apache/arrow/vector/Decimal256Vector.java#L150) takes care of it. Do we handle this in this PR?
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org