You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "KeDeng (Code Review)" <ge...@cloudera.org> on 2022/10/08 02:00:04 UTC

[kudu-CR] [test] make master authz-itest more robust

Hello Yingchun Lai, Kudu Jenkins, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/19053

to look at the new patch set (#3).

Change subject: [test] make master_authz-itest more robust
......................................................................

[test] make master_authz-itest more robust

I note the master_authz-itest unit-test may fail like this :
`
I20220929 10:56:08.093688   728 heartbeater.cc:466] Master 127.31.156.254:23975 was elected leader, sending a full tablet report...
9月 29 10:56:16 10-120-18-85 krb5kdc[32375](info): TGS_REQ (2 etypes {17 16}) 127.0.0.1: ISSUE: authtime 1664420166, etypes {rep=17 tkt=17 ses=17}, kudu/127.31.156.254@KRBTEST.COM for HTTP/127.31.156.212@KRBTEST.COM
I20220929 10:56:17.372444   532 master_service.cc:901] request to refresh authz privileges cache from {username='test-admin', principal='test-admin@KRBTEST.COM'} at 127.0.0.1:17302
/data/github-kudu/kudu/src/kudu/integration-tests/master_authz-itest.cc:597: Failure
Failed
Bad status: Timed out: RefreshAuthzCache RPC to 127.31.156.254:23975 timed out after 10.000s (SENT)
/data/github-kudu/kudu/src/kudu/integration-tests/master_authz-itest.cc:1083: Failure
Expected: SetUpCluster(std::get<0>(GetParam())) doesn't generate new fatal failures in the current thread.
  Actual: it does.
I20220929 10:56:27.373370 32371 external_mini_cluster-itest-base.cc:80] Found fatal failure
`
I have tested this case many times and found that all the failure is due to timeout.
So I add retry policy for timeout to avoid direct failure in case of timeout.

Change-Id: I2da13d18a8d7d6bcff5a41cdbad6d6ade6d528f3
---
M src/kudu/integration-tests/master_authz-itest.cc
1 file changed, 107 insertions(+), 107 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/53/19053/3
-- 
To view, visit http://gerrit.cloudera.org:8080/19053
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2da13d18a8d7d6bcff5a41cdbad6d6ade6d528f3
Gerrit-Change-Number: 19053
Gerrit-PatchSet: 3
Gerrit-Owner: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: KeDeng <kd...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>