You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by Jeremy Boynes <jb...@apache.org> on 2013/07/22 20:09:32 UTC

Can anyone provide history for something in JspC?

This snippet from initClassLoader()
>         // What is this ??
>         urls.add(new File(
>                 clctxt.getRealPath("/")).getCanonicalFile().toURI().toURL());
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/JspC.java?view=markup#l1505

It's in the original import into SVN and I don't know where CVS is any more. It seems to be adding the root of the web application into JspC's webapp ClassLoader but I don't think why it would do that as that should not be on the classpath. 

I would like to remove this to remove any dependency on the JspCompilationContext so I can refactor initialization of the ClassLoader into JspCServletContext and create the ClassLoader once per run rather than create a new one for each file.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Can anyone provide history for something in JspC?

Posted by Jeremy Boynes <jb...@apache.org>.
On Jul 22, 2013, at 11:22 AM, Mark Thomas <ma...@apache.org> wrote:

> On 22/07/2013 19:09, Jeremy Boynes wrote:
>> This snippet from initClassLoader()
>>>        // What is this ??
>>>        urls.add(new File(
>>>                clctxt.getRealPath("/")).getCanonicalFile().toURI().toURL());
>> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/JspC.java?view=markup#l1505
>> 
>> It's in the original import into SVN and I don't know where CVS is any more.
> 
> Everything from cvs is in svn.
> 
> You need to go back to 4.1.x as that is where the current sources were
> copied from:
> 
> http://svn.apache.org/viewvc/tomcat/archive/tc4.1.x/trunk/jasper/src/share/org/apache/jasper/JspC.java?view=log
> 
> You might need to go even further back:
> http://svn.apache.org/viewvc/tomcat/archive/jasper/

Best I've found is that this was added in the import of jasper2:
  http://svn.apache.org/viewvc/tomcat/jasper/trunk/jasper2/src/share/org/apache/jasper/JspC.java?revision=304852&view=markup&pathrev=304852#l399
and that it was not in the original jasper:
  http://svn.apache.org/viewvc/tomcat/jasper/trunk/jasper34/liaison/org/apache/jasper34/cli/CommandLineContext.java?revision=304832&view=markup&pathrev=304832#190

I think the change was made externally in cleanup prior to the import of jasper2.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org


Re: Can anyone provide history for something in JspC?

Posted by Mark Thomas <ma...@apache.org>.
On 22/07/2013 19:09, Jeremy Boynes wrote:
> This snippet from initClassLoader()
>>         // What is this ??
>>         urls.add(new File(
>>                 clctxt.getRealPath("/")).getCanonicalFile().toURI().toURL());
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/JspC.java?view=markup#l1505
> 
> It's in the original import into SVN and I don't know where CVS is any more.

Everything from cvs is in svn.

You need to go back to 4.1.x as that is where the current sources were
copied from:

http://svn.apache.org/viewvc/tomcat/archive/tc4.1.x/trunk/jasper/src/share/org/apache/jasper/JspC.java?view=log

You might need to go even further back:
http://svn.apache.org/viewvc/tomcat/archive/jasper/

Mark


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org