You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/06/11 01:54:01 UTC

[GitHub] [incubator-dolphinscheduler] gabrywu edited a comment on pull request #2832: Modify OracleDB connection string format.

gabrywu edited a comment on pull request #2832:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/2832#issuecomment-642357673


   > > It's better not to change the scope of appendDatabase. You can override the getJdbcUrl directly
   > 
   > lgcareer has reviewed the code, this method is no problem. The restriction also requires you to modify and review it, thank you
   
   done. thanks for your contribution


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org