You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2018/05/24 15:25:54 UTC

[kudu-CR] [docs] KUDU-2107 Document how to add reviewers 

Hello Dan Burkert,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/10501

to review the following change.


Change subject: [docs] KUDU-2107 Document how to add reviewers
......................................................................

[docs] KUDU-2107 Document how to add reviewers

The contribution guidelines didn't mention how to add reviewers to
gerrit. This patch documents this process and also adds a tip about how
to find possible reviewers for a patch

Change-Id: I102e5062d1c31828ad1246b021abcede9b4a88f5
---
M docs/contributing.adoc
1 file changed, 12 insertions(+), 0 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/01/10501/1
-- 
To view, visit http://gerrit.cloudera.org:8080/10501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I102e5062d1c31828ad1246b021abcede9b4a88f5
Gerrit-Change-Number: 10501
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>

[kudu-CR] [docs] KUDU-2107 Document how to add reviewers

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change. ( http://gerrit.cloudera.org:8080/10501 )

Change subject: [docs] KUDU-2107 Document how to add reviewers
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/10501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I102e5062d1c31828ad1246b021abcede9b4a88f5
Gerrit-Change-Number: 10501
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Wed, 30 May 2018 22:04:38 +0000
Gerrit-HasComments: No

[kudu-CR] [docs] KUDU-2107 Document how to add reviewers

Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10501 )

Change subject: [docs] KUDU-2107 Document how to add reviewers
......................................................................

[docs] KUDU-2107 Document how to add reviewers

The contribution guidelines didn't mention how to add reviewers to
gerrit. This patch documents this process and also adds a tip about how
to find possible reviewers for a patch

Change-Id: I102e5062d1c31828ad1246b021abcede9b4a88f5
Reviewed-on: http://gerrit.cloudera.org:8080/10501
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M docs/contributing.adoc
1 file changed, 12 insertions(+), 0 deletions(-)

Approvals:
  Kudu Jenkins: Verified
  Dan Burkert: Looks good to me, approved

-- 
To view, visit http://gerrit.cloudera.org:8080/10501
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I102e5062d1c31828ad1246b021abcede9b4a88f5
Gerrit-Change-Number: 10501
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins