You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/03/27 11:27:05 UTC
[GitHub] [fineract] vidakovic opened a new pull request #2193: FINERACT-1552: Upgrade fineract-client to OpenAPI generator 5.4.0
vidakovic opened a new pull request #2193:
URL: https://github.com/apache/fineract/pull/2193
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/api-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2193: FINERACT-1552: Upgrade fineract-client to OpenAPI generator 5.4.0
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2193:
URL: https://github.com/apache/fineract/pull/2193#issuecomment-1083944949
@vorburger ... just saw that you already implemented upload tests with image and document client API... the tests pass, so I think we are good here... of course we could always use more tests... have some separate test related PRs where I can circle back to that later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on a change in pull request #2193: FINERACT-1552: Upgrade fineract-client to OpenAPI generator 5.4.0
Posted by GitBox <gi...@apache.org>.
vidakovic commented on a change in pull request #2193:
URL: https://github.com/apache/fineract/pull/2193#discussion_r838955066
##########
File path: integration-tests/src/test/java/org/apache/fineract/integrationtests/client/ClientTest.java
##########
@@ -65,7 +65,8 @@ Long create() {
fineract().clients.retrieveAll21(null, null, null, null, null, null, null, null, 0, 1, null, null, false));
if (clients.getTotalFilteredRecords() > 0) {
// TODO rm long cast, see https://issues.apache.org/jira/browse/FINERACT-1230
- return Optional.of((long) clients.getPageItems().get(0).getId());
+ return clients.getPageItems().stream().findFirst().map(item -> item.getId().longValue());
+ // return Optional.of((long) clients.getPageItems().stream().findFirst().get().getId());
Review comment:
Yup... one more round to demonstrate that the uploads are (well, at least one unit test) working with the new client (as Michael suggested... this was the initial blocker why we couldn't upgrade)... and with that I'll cleanup this here too.
:+1:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a change in pull request #2193: FINERACT-1552: Upgrade fineract-client to OpenAPI generator 5.4.0
Posted by GitBox <gi...@apache.org>.
galovics commented on a change in pull request #2193:
URL: https://github.com/apache/fineract/pull/2193#discussion_r838718023
##########
File path: integration-tests/src/test/java/org/apache/fineract/integrationtests/client/ClientTest.java
##########
@@ -65,7 +65,8 @@ Long create() {
fineract().clients.retrieveAll21(null, null, null, null, null, null, null, null, 0, 1, null, null, false));
if (clients.getTotalFilteredRecords() > 0) {
// TODO rm long cast, see https://issues.apache.org/jira/browse/FINERACT-1230
- return Optional.of((long) clients.getPageItems().get(0).getId());
+ return clients.getPageItems().stream().findFirst().map(item -> item.getId().longValue());
+ // return Optional.of((long) clients.getPageItems().stream().findFirst().get().getId());
Review comment:
I guess we wanna uncomment this or remove the commented code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2193: FINERACT-1552: Upgrade fineract-client to OpenAPI generator 5.4.0
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2193:
URL: https://github.com/apache/fineract/pull/2193#issuecomment-1083982060
@vorburger I've changed the typs from Integer to Long in the Swagger descriptor. I agree with you that we should "standardize" on Long for IDs. This specific change was easy and should have no further side effects (other than it generates a nicer API client). For the JSON de-/serialization this change doesn't matter anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic merged pull request #2193: FINERACT-1552: Upgrade fineract-client to OpenAPI generator 5.4.0
Posted by GitBox <gi...@apache.org>.
vidakovic merged pull request #2193:
URL: https://github.com/apache/fineract/pull/2193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #2193: FINERACT-1552: Upgrade fineract-client to OpenAPI generator 5.4.0
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #2193:
URL: https://github.com/apache/fineract/pull/2193#issuecomment-1080018330
@vidakovic how about client tests for this new UploadRequest and DocumentUploadRequest?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2193: FINERACT-1552: Upgrade fineract-client to OpenAPI generator 5.4.0
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2193:
URL: https://github.com/apache/fineract/pull/2193#issuecomment-1080027742
Hmmm... that's odd... JSON syntax errors in places where I didn't change a thing... have to look into this a bit more...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vidakovic commented on pull request #2193: FINERACT-1552: Upgrade fineract-client to OpenAPI generator 5.4.0
Posted by GitBox <gi...@apache.org>.
vidakovic commented on pull request #2193:
URL: https://github.com/apache/fineract/pull/2193#issuecomment-1080018738
@vorburger ... sure... I've used the LoanApiResource to test if everything is still working with the "normal" integration tests... I can see to replicate that... but apparently there's still an error to be solved. But overall I think this strategy should work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org