You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2022/11/07 05:50:33 UTC

[GitHub] [lucenenet] NightOwl888 commented on pull request #745: Added sonarcloud badge

NightOwl888 commented on PR #745:
URL: https://github.com/apache/lucenenet/pull/745#issuecomment-1305117742

   Thanks. This will make a great addition, except I think we should hold off on merging it until after we have:
   
   1. Updated the CONTRIBUTING.md page to inform contributors not to submit PRs for random things out of the scan that we haven't decided whether or not we will fix.
   2. Added a [PR template](https://docs.github.com/en/communities/using-templates-to-encourage-useful-issues-and-pull-requests/about-issue-and-pull-request-templates) indicating that only approved issues from SonarCloud will be accepted (approved being that they have been made into a GitHub issue). The PR templates would also allow us to put other guardrails in place so we don't have to reject PRs for people who were just trying to help out, but submitted something we cannot use in this version of Lucene.NET.
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@lucenenet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org