[GitHub] [hadoop] goiri commented on a diff in pull request #5071: HDFS-16816 RBF: auto-create user home dir for trash paths by router

[GitBox <gi...@apache.org>]

goiri commented on code in PR #5071:
URL: https://github.com/apache/hadoop/pull/5071#discussion_r1012250183


##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterClientProtocol.java:
##########
@@ -734,6 +811,13 @@ public boolean mkdirs(String src, FsPermission masked, boolean createParent)
         new Class<?>[] {String.class, FsPermission.class, boolean.class},
         new RemoteParam(), masked, createParent);
 
+    // Auto-create user home dir for a trash path.
+    // moveToTrash() will first call fs.mkdirs() to create the parent dir, before calling rename()
+    // to move the file into it. As a result, we need to create user home dir in mkdirs().
+    if (autoCreateUserHomeForTrash) {
+      createUserHomeForTrashPath(src, locations);

Review Comment:
   Given that we already have provisionEZTrash(), it does make sense to do the same for this.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org