You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shenyu.apache.org by "lianjunwei (via GitHub)" <gi...@apache.org> on 2023/06/08 15:50:51 UTC
[GitHub] [shenyu] lianjunwei opened a new pull request, #4718: [optimize #4717] optimize code style.
lianjunwei opened a new pull request, #4718:
URL: https://github.com/apache/shenyu/pull/4718
#4717
Optimized the Programming style of some classes.
Use Objects Judgment Null Or NotNull.
Objects.isNull(obj) OR Objects.nonNull(obj)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] codecov-commenter commented on pull request #4718: [optimize #4717] optimize code style.
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #4718:
URL: https://github.com/apache/shenyu/pull/4718#issuecomment-1583804501
## [Codecov](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4718](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (8636bc6) into [master](https://app.codecov.io/gh/apache/shenyu/commit/bc16c5fdc36d9df337286f5fb16321464c1f11a0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (bc16c5f) will **decrease** coverage by `0.18%`.
> The diff coverage is `34.78%`.
```diff
@@ Coverage Diff @@
## master #4718 +/- ##
============================================
- Coverage 66.45% 66.27% -0.18%
- Complexity 8004 8009 +5
============================================
Files 1109 1111 +2
Lines 32044 32166 +122
Branches 2896 2905 +9
============================================
+ Hits 21294 21319 +25
- Misses 9060 9153 +93
- Partials 1690 1694 +4
```
| [Impacted Files](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...tener/http/HttpLongPollingDataChangedListener.java](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vbGlzdGVuZXIvaHR0cC9IdHRwTG9uZ1BvbGxpbmdEYXRhQ2hhbmdlZExpc3RlbmVyLmphdmE=) | `5.88% <0.00%> (ø)` | |
| [...e/shenyu/admin/service/impl/DetailServiceImpl.java](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0RldGFpbFNlcnZpY2VJbXBsLmphdmE=) | `77.55% <0.00%> (ø)` | |
| [...he/shenyu/admin/service/impl/FieldServiceImpl.java](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vc2VydmljZS9pbXBsL0ZpZWxkU2VydmljZUltcGwuamF2YQ==) | `88.46% <0.00%> (ø)` | |
| [.../java/org/apache/shenyu/admin/utils/HttpUtils.java](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWFkbWluL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGVueXUvYWRtaW4vdXRpbHMvSHR0cFV0aWxzLmphdmE=) | `36.72% <0.00%> (ø)` | |
| [.../java/org/apache/shenyu/common/utils/MapUtils.java](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NvbW1vbi91dGlscy9NYXBVdGlscy5qYXZh) | `37.50% <0.00%> (ø)` | |
| [...henyu/plugin/brpc/spi/SharedThreadPoolFactory.java](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWJycGMvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vYnJwYy9zcGkvU2hhcmVkVGhyZWFkUG9vbEZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...henyu/plugin/httpclient/NettyHttpClientPlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLWh0dHBjbGllbnQvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vaHR0cGNsaWVudC9OZXR0eUh0dHBDbGllbnRQbHVnaW4uamF2YQ==) | `35.71% <0.00%> (ø)` | |
| [...java/org/apache/shenyu/plugin/sofa/SofaPlugin.java](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXBsdWdpbi9zaGVueXUtcGx1Z2luLXNvZmEvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoZW55dS9wbHVnaW4vc29mYS9Tb2ZhUGx1Z2luLmphdmE=) | `82.75% <0.00%> (ø)` | |
| [...g/apache/shenyu/web/loader/ShenyuPluginLoader.java](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LXdlYi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L3dlYi9sb2FkZXIvU2hlbnl1UGx1Z2luTG9hZGVyLmphdmE=) | `73.01% <0.00%> (ø)` | |
| [.../dubbo/validation/AlibabaDubboClientValidator.java](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2hlbnl1LWNsaWVudC9zaGVueXUtY2xpZW50LWR1YmJvL3NoZW55dS1jbGllbnQtYWxpYmFiYS1kdWJiby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hlbnl1L2NsaWVudC9hbGliYWJhL2R1YmJvL3ZhbGlkYXRpb24vQWxpYmFiYUR1YmJvQ2xpZW50VmFsaWRhdG9yLmphdmE=) | `89.79% <33.33%> (ø)` | |
| ... and [8 more](https://app.codecov.io/gh/apache/shenyu/pull/4718?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [24 files with indirect coverage changes](https://app.codecov.io/gh/apache/shenyu/pull/4718/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shenyu] yu199195 merged pull request #4718: [optimize #4717] optimize code style.
Posted by "yu199195 (via GitHub)" <gi...@apache.org>.
yu199195 merged PR #4718:
URL: https://github.com/apache/shenyu/pull/4718
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shenyu.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org